all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit v6 10/16] notification: matcher: match-field: show known fields/values
Date: Mon, 22 Apr 2024 10:52:52 +0200	[thread overview]
Message-ID: <4a228548-ca8e-457f-9919-f085bdcc71dc@proxmox.com> (raw)
In-Reply-To: <20240422083116.99809-11-l.wagner@proxmox.com>

Am 22.04.24 um 10:31 schrieb Lukas Wagner:
> @@ -416,10 +416,22 @@ Ext.define('Proxmox.panel.NotificationRulesEditPanel', {
>  		    let me = this;
>  		    let record = me.get('selectedRecord');
>  		    let currentData = record.get('data');
> +
> +		    let newValue = [];
> +
> +		    // Build equivalent regular expression if switching
> +		    // to 'regex' mode
> +		    if (value === 'regex') {
> +			let regexVal = "^(";
> +			regexVal += currentData.value.join('|') + ")$";

Can break the UI when you change the match type before there is a value:

> Uncaught TypeError: currentData.value.join is not a function

> +			newValue.push(regexVal);
> +		    }
> +

and nit: the above could/should be a separate patch

>  		    record.set({
>  			data: {
>  			    ...currentData,
>  			    type: value,
> +			    value: newValue,
>  			},
>  		    });
>  		},

---snip---

> +	let valueStore = Ext.create('Ext.data.Store', {
> +	    model: 'proxmox-notification-field-values',
> +	    autoLoad: true,
> +	    proxy: {
> +		type: 'proxmox',
> +
> +		url: `/api2/json/${me.baseUrl}/matcher-field-values`,
> +	    },
> +	    listeners: {
> +		'load': function() {
> +		    this.each(function(record) {
> +			if (record.get('field') === 'type') {
> +			    record.set({
> +				comment:

Nit: while the API does not return a comment for the 'type' field
currently, this would override the returned comment should there ever be
one in the future.

> +				    Proxmox.Utils.formatNotificationFieldValue(
> +					record.get('value'),
> +				    ),
> +			    });
> +			}
> +		    }, this, true);
> +
> +		    // Commit changes so that the description field is not marked
> +		    // as dirty
> +		    this.commitChanges();
> +		},
> +	    },
> +	});
> +


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-04-22  8:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22  8:31 [pve-devel] [PATCH docs/guest-common/manager/widget-toolkit v6 00/16] notifications: notification metadata matching improvements Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH pve-guest-common v6 01/16] vzdump: common: allow 'job-id' as a parameter without being in schema Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH manager v6 02/16] api: jobs: vzdump: pass job 'job-id' parameter Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH manager v6 03/16] ui: dc: backup: send 'job-id' property when starting a backup job manually Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH manager v6 04/16] ui: dc: backup: allow to set custom job id in advanced settings Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH manager v6 05/16] api: replication: add 'job-id' to notification metadata Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH manager v6 06/16] vzdump: apt: notification: do not include domain in 'hostname' field Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH manager v6 07/16] api: replication: include 'hostname' field for notifications Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH manager v6 08/16] api: notification: add API for getting known metadata fields/values Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH manager v6 09/16] ui: utils: add overrides for translatable notification fields/values Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH widget-toolkit v6 10/16] notification: matcher: match-field: show known fields/values Lukas Wagner
2024-04-22  8:52   ` Fiona Ebner [this message]
2024-04-22  8:31 ` [pve-devel] [PATCH widget-toolkit v6 11/16] notification: matcher: move match-field formulas to local viewModel Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH widget-toolkit v6 12/16] notification: matcher: move match-calendar fields to panel Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH widget-toolkit v6 13/16] notification: matcher: move match-severity " Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH docs v6 14/16] notification: clarify that 'hostname' does not include the domain Lukas Wagner
2024-04-22  8:31 ` [pve-devel] [PATCH docs v6 15/16] notifications: describe new notification metadata fields Lukas Wagner
2024-04-22  9:10   ` Fiona Ebner
2024-04-22  9:15     ` Lukas Wagner
2024-04-22  9:20       ` Fiona Ebner
2024-04-22  8:31 ` [pve-devel] [PATCH docs v6 16/16] notifications: match-field 'exact'-mode can now match multiple values Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a228548-ca8e-457f-9919-f085bdcc71dc@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal