From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox-backup] proxmox-restore-daemon: keep daemon active during extract api call
Date: Fri, 14 May 2021 10:58:42 +0200 [thread overview]
Message-ID: <49e3c3f9-9042-1f90-a572-225d90e8b717@proxmox.com> (raw)
In-Reply-To: <659aa238-6077-5fc5-0f1b-f886a493aca5@proxmox.com>
On 5/14/21 10:54, Thomas Lamprecht wrote:
> On 14.05.21 10:42, Dominik Csapak wrote:
>> we only called watchdog_ping on the start of an api call, which meant
>> that if a single zip/pxar download took longer than 10 minutes
>> (which can happen on larger vms/slower connections), we shut-down
>> the vm and cancelled the download.
>>
>> instead, spawn a second future, that polls both a sleep and the extract
>> handle, and ping the watchdog every 60 seconds
>>
>
> This is known and Stefan send a patch for this last week[0], which was OK but
> delayed due to the tokio DuplexStream bug he also fixed where we did not
> decided then if we still use his workaround after upstream already merged
> the fix.
>
> IIRC your approach has some drawbacks, especially without the workaround fixed,
> but just some fain memory - in any way I'll go for Stefan's series.
>
> [0]: https://lists.proxmox.com/pipermail/pbs-devel/2021-May/003106.html
>
ah yes i see it now, thanks :)
prev parent reply other threads:[~2021-05-14 8:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 8:42 Dominik Csapak
2021-05-14 8:54 ` Thomas Lamprecht
2021-05-14 8:58 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49e3c3f9-9042-1f90-a572-225d90e8b717@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.