Re: [pve-devel] [RFC storage 1/3] plugin: add method to get qemu blockdevice options for volume

[Fiona Ebner <f.ebner@proxmox.com>]

Am 23.05.25 um 11:15 schrieb DERUMIER, Alexandre:
>>> Good point! I guess it's better to also do the activation in qemu-
>>> server
>>> then, so that we can match it up nicely without going over package
>>> boundaries.
> 
> Ok, I'll add the activate in qemu-server too
> 
> 
> 
> Just found another bug:
> 
> PVE/Storage.pm 
> 
> sub qemu_blockdev_options {
>     my ($cfg, $volid, $snapname) = @_;
> 
>     my ($storeid, $volname) = parse_volume_id($volid);
> 
> 
> This fail with $volid=/dev/cdrom   (with ide2:cdrom)
> # got unexpected error: unable to parse volume ID 'cdrom'
> 
> and maybe (not have tested it) , if user have configured manually dev
> passthrough like : "scsi1: /dev/...."

I intentionally do not handle CD-ROMs, qemu-server should be concerned
with doing that. There is a comment about this ;)

> +	# The 'file' driver only works for regular files. The check below is taken from
> +	# block/file-posix.c:hdev_probe_device() in QEMU. Do not bother with detecting 'host_cdrom'
> +	# devices here, those are not managed by the storage layer.

Best Regards,
Fiona


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel