From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup v2 1/2] tape: hide internal use of all zero uuid for unassigned tapes
Date: Wed, 30 Nov 2022 17:32:35 +0100 [thread overview]
Message-ID: <49a2df97-dc87-8398-6567-5df274b49705@proxmox.com> (raw)
In-Reply-To: <20221129141701.4109478-1-d.csapak@proxmox.com>
Am 29/11/2022 um 15:17 schrieb Dominik Csapak:
> a tape assigned to a pool but no media-set, gets the special 'all zero'
> media set in it's MediaSetLabel. Instead of having that constant
> scattered all over the code, hide this fact by using wrapper functions
> to initialize it that way and to check for it
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> replaces my previous patch:
> tape: refactor uuid of empty media set into constant
>
> src/api2/tape/drive.rs | 6 +++---
> src/api2/tape/media.rs | 3 +--
> src/tape/file_formats/mod.rs | 8 ++++++++
> src/tape/inventory.rs | 26 +++++++++++---------------
> src/tape/media_pool.rs | 2 +-
> 5 files changed, 24 insertions(+), 21 deletions(-)
>
>
applied both patches, thanks!
ps. I like those commit subjects/messages, many thanks for making my work
slightly easier (it adds up).
prev parent reply other threads:[~2022-11-30 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 14:17 [pbs-devel] " Dominik Csapak
2022-11-29 14:17 ` [pbs-devel] [PATCH proxmox-backup v2 2/2] tape: inventory: skip " Dominik Csapak
2022-11-30 16:32 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49a2df97-dc87-8398-6567-5df274b49705@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.