From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Jona Draaijer <jcdra1@gmail.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: Re: [pve-devel] GET /access/users/{userid} has parameter 'tokens' with 'additionalProperties' containing object definition
Date: Tue, 2 Apr 2024 09:27:57 +0200 (CEST) [thread overview]
Message-ID: <491134625.3322.1712042877345@webmail.proxmox.com> (raw)
In-Reply-To: <mailman.784.1712001709.434.pve-devel@lists.proxmox.com>
> Jona Draaijer via pve-devel <pve-devel@lists.proxmox.com> hat am 01.04.2024 22:00 CEST geschrieben:
> Hi,
>
> As per the title, that endpoint has an additionalProperties value that is
> not a bool, but rather an object definition. (It's defined in
> pve-access-control/src/PVE/API2/User.pm).
>
> As far as I can tell, all other 'additionalProperties' are bools. Does
> anyone know why this specific one is different, or if this difference is
> intentional?
I think this was just an accident.
> From the looks of it it seems like it's used as a "we need this standard
> option, but also have to make it optional". I am still quite new to perl,
> so I don't know if there is a way to do what was intended.
My guess is the intent was to have
tokens => get_standard_option('token-info', { optional => 1 }),
instead, @Wolfgang?
next parent reply other threads:[~2024-04-02 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.784.1712001709.434.pve-devel@lists.proxmox.com>
2024-04-02 7:27 ` Fabian Grünbichler [this message]
2024-04-02 8:00 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491134625.3322.1712042877345@webmail.proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=jcdra1@gmail.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.