From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] auto-installer: move ssh keys setup to low-level installer
Date: Tue, 23 Apr 2024 17:26:02 +0200 [thread overview]
Message-ID: <490275c4-cf64-4e07-9e5c-fbc26fc08af3@proxmox.com> (raw)
In-Reply-To: <20240423144451.889535-1-c.heiss@proxmox.com>
Am 23/04/2024 um 16:44 schrieb Christoph Heiss:
> .. thereby, also fixing a accidental shell injection.
>
> Since run_cmd{,s}() is nowhere else used anymore, they can be removed
> too.
>
> Also mostly reverts commit
>
> 5878dc4ae "auto-installer: handle auto-reboot info messages directly"
>
would have preferred a bit more reasoning and possibly having this split
in two patches, but fine enough I guess.
> in the process too.
>
> Reported-by: Friedrich Weber <f.weber@proxmox.com>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Proxmox/Install.pm | 7 ++
> Proxmox/Install/Config.pm | 4 ++
> .../src/bin/proxmox-auto-installer.rs | 34 +--------
> proxmox-auto-installer/src/utils.rs | 70 ++-----------------
> .../resources/parse_answer/disk_match.json | 2 +-
> .../parse_answer/disk_match_all.json | 2 +-
> .../parse_answer/disk_match_any.json | 2 +-
> .../tests/resources/parse_answer/minimal.json | 2 +-
> .../resources/parse_answer/nic_matching.json | 2 +-
> .../resources/parse_answer/specific_nic.json | 2 +-
> .../tests/resources/parse_answer/zfs.json | 2 +-
> proxmox-installer-common/src/setup.rs | 2 +
> proxmox-tui-installer/src/setup.rs | 1 +
> 13 files changed, 27 insertions(+), 105 deletions(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-23 15:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 14:44 [pve-devel] " Christoph Heiss
2024-04-23 15:26 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490275c4-cf64-4e07-9e5c-fbc26fc08af3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal