all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v10 manager 1/1] api: nodes: add readovf endpoint
Date: Tue, 18 Jan 2022 09:35:38 +0100	[thread overview]
Message-ID: <48c3e875-a4fb-a263-c4f2-49c21d6facec@proxmox.com> (raw)
In-Reply-To: <1642418050.f53h13is6j.astroid@nora.none>

Am 17.01.22 um 16:38 schrieb Fabian Grünbichler:
> missing a reason why this is added to the generic node index, and not
> somewhere under qemu?
>

I suppose because having it under /nodes/{node}/qemu/ would imply having 
it under /nodes/{node}/qemu/{vmid}/ (as we don't support having both 
path/{regex} and path/static at the same time), but it doesn't depend on 
any vmid?


> On January 13, 2022 11:08 am, Fabian Ebner wrote:
>> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
>> [split into its own patch + add to index]
>> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
>> ---
>>
>> Needs dependency bump for qemu-server.
>>
>> Changes from v9:
>>      * Add entry to /node/'s index.
>>
>>   PVE/API2/Nodes.pm | 7 +++++++
>>   1 file changed, 7 insertions(+)
>>
>> diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
>> index d57a1937..5f6208d5 100644
>> --- a/PVE/API2/Nodes.pm
>> +++ b/PVE/API2/Nodes.pm
>> @@ -49,6 +49,7 @@ use PVE::API2::LXC;
>>   use PVE::API2::Network;
>>   use PVE::API2::NodeConfig;
>>   use PVE::API2::Qemu::CPU;
>> +use PVE::API2::Qemu::OVF;
>>   use PVE::API2::Qemu;
>>   use PVE::API2::Replication;
>>   use PVE::API2::Services;
>> @@ -71,6 +72,11 @@ __PACKAGE__->register_method ({
>>       path => 'qemu',
>>   });
>>   
>> +__PACKAGE__->register_method ({
>> +    subclass => "PVE::API2::Qemu::OVF",
>> +    path => 'readovf',
>> +});
>> +
>>   __PACKAGE__->register_method ({
>>       subclass => "PVE::API2::LXC",
>>       path => 'lxc',
>> @@ -233,6 +239,7 @@ __PACKAGE__->register_method ({
>>   	    { name => 'network' },
>>   	    { name => 'qemu' },
>>   	    { name => 'query-url-metadata' },
>> +	    { name => 'readovf' },
>>   	    { name => 'replication' },
>>   	    { name => 'report' },
>>   	    { name => 'rrd' }, # fixme: remove?
>> -- 
>> 2.30.2
>>
>>
>>
>> _______________________________________________
>> pve-devel mailing list
>> pve-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
>>
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel




  reply	other threads:[~2022-01-18  8:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-13 10:08 [pve-devel] [RFC v10 qemu-server/manager] API for disk import and OVF Fabian Ebner
2022-01-13 10:08 ` [pve-devel] [PATCH v10 qemu-server 1/7] schema: add pve-volume-id-or-absolute-path Fabian Ebner
2022-01-13 10:08 ` [pve-devel] [PATCH v10 qemu-server 2/7] parse ovf: untaint path when calling file_size_info Fabian Ebner
     [not found]   ` <<20220113100831.34113-3-f.ebner@proxmox.com>
2022-01-17 15:38     ` Fabian Grünbichler
2022-01-13 10:08 ` [pve-devel] [PATCH v10 qemu-server 3/7] api: add endpoint for parsing .ovf files Fabian Ebner
2022-01-13 10:08 ` [pve-devel] [PATCH v10 manager 1/1] api: nodes: add readovf endpoint Fabian Ebner
     [not found]   ` <<20220113100831.34113-5-f.ebner@proxmox.com>
2022-01-17 15:38     ` Fabian Grünbichler
2022-01-18  8:35       ` Fabian Ebner [this message]
2022-01-18  9:56         ` Fabian Grünbichler
2022-01-13 10:08 ` [pve-devel] [PATCH v10 qemu-server 4/7] image convert: allow block device as source Fabian Ebner
2022-01-13 10:08 ` [pve-devel] [RFC v10 qemu-server 5/7] schema: drive: use separate schema when disk allocation is possible Fabian Ebner
2022-01-13 10:08 ` [pve-devel] [RFC v10 qemu-server 6/7] api: support VM disk import Fabian Ebner
     [not found]   ` <<20220113100831.34113-8-f.ebner@proxmox.com>
2022-01-17 15:39     ` Fabian Grünbichler
2022-01-18  8:51       ` Fabian Ebner
2022-01-26 11:40   ` Fabian Ebner
2022-01-26 12:42     ` Fabian Grünbichler
2022-01-27  8:21       ` Fabian Ebner
2022-01-27 10:43         ` Fabian Grünbichler
2022-02-22 12:11   ` Fabian Ebner
2022-02-22 15:33     ` Fabian Grünbichler
2022-01-13 10:08 ` [pve-devel] [RFC v10 qemu-server 7/7] api: create disks: factor out common part from if/else Fabian Ebner
     [not found] ` <<20220113100831.34113-1-f.ebner@proxmox.com>
2022-01-17 15:43   ` [pve-devel] [RFC v10 qemu-server/manager] API for disk import and OVF Fabian Grünbichler
2022-01-18  9:08     ` Fabian Ebner
2022-01-18 10:19       ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48c3e875-a4fb-a263-c4f2-49c21d6facec@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal