From: Dominik Csapak <d.csapak@proxmox.com>
To: Dietmar Maurer <dietmar@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>
Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup 0/5] various bug fixes/improvements for gc
Date: Tue, 3 Nov 2020 08:14:39 +0100 [thread overview]
Message-ID: <48b00d80-a6ce-0d98-014d-647681440d7a@proxmox.com> (raw)
In-Reply-To: <1427468580.642.1604380298736@webmail.proxmox.com>
On 11/3/20 6:11 AM, Dietmar Maurer wrote:
>> return Err(format_err!(
>> "cannot open index {}: {}",
>> full_path.to_string_lossy(),
>> err,
>> ));
>>
>> is:
>>
>> bail!("can't open index {} - {}", path.to_string_lossy(), err),
>
> btw, I normally use the following instead:
>
> bail!("can't open index {:?} - {}", path, err),
>
yes that is better... (i somehow thought that would print the path as
byte array, idk why i thought that)
prev parent reply other threads:[~2020-11-03 7:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-02 11:34 [pbs-devel] " Dominik Csapak
2020-11-02 11:34 ` [pbs-devel] [PATCH proxmox-backup 1/5] garbage collect: improve index error messages Dominik Csapak
2020-11-02 11:34 ` [pbs-devel] [PATCH proxmox-backup 2/5] backup/{dynamic, fixed}_index: improve error message for small index files Dominik Csapak
2020-11-02 11:34 ` [pbs-devel] [PATCH proxmox-backup 3/5] server/gc_job: add 'to_stdout' Dominik Csapak
2020-11-02 11:34 ` [pbs-devel] [PATCH proxmox-backup 4/5] api2/admin/datastore: start the garbage_collection task with our helper Dominik Csapak
2020-11-03 5:45 ` Dietmar Maurer
2020-11-03 6:54 ` Dominik Csapak
2020-11-02 11:34 ` [pbs-devel] [PATCH proxmox-backup 5/5] proxmox-backup-proxy: use only jobstate for garbage_collection schedule Dominik Csapak
2020-11-02 20:12 ` [pbs-devel] applied: [PATCH proxmox-backup 0/5] various bug fixes/improvements for gc Thomas Lamprecht
2020-11-03 5:11 ` Dietmar Maurer
2020-11-03 7:14 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48b00d80-a6ce-0d98-014d-647681440d7a@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=dietmar@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.