From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] network: sync option names with pve-common
Date: Thu, 24 Jun 2021 11:01:05 +0200 [thread overview]
Message-ID: <48ae22a7-a690-df42-b19f-2093bd2e8413@proxmox.com> (raw)
In-Reply-To: <20210624072936.723195-1-f.gruenbichler@proxmox.com>
On 24.06.21 09:29, Fabian Grünbichler wrote:
> back in 2018, commit 1accc6da659d8a02dcf1c2a636749e6f48fb9c2d
> "Inotify : write network config : use modern syntax for options"
> changed pve-common's /etc/network/interfaces writer to prefer options
> with '-' over those with '_'.
>
> having the installer write the old variant makes any modification of the
> vmbr0 interface via the API also change these three lines to the new
> variant - so let's do it right from the start.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> https://forum.proxmox.com/threads/wrong-elaboration-of-etc-network-interface-by-proxmox-gui.91271/
>
> proxinstall | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
nice catch, applied, thanks!
prev parent reply other threads:[~2021-06-24 9:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 7:29 [pve-devel] " Fabian Grünbichler
2021-06-24 9:01 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ae22a7-a690-df42-b19f-2093bd2e8413@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal