From: Friedrich Weber <f.weber@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC storage] content-dirs: check that all content dirs are pairwise inequal
Date: Wed, 7 Jun 2023 12:18:49 +0200 [thread overview]
Message-ID: <4855967b-49f1-1de1-d79c-a03600c503ed@proxmox.com> (raw)
In-Reply-To: <3cccc262-6972-697a-3d97-0cd1bd96edbf@proxmox.com>
On 07/06/2023 12:01, Fiona Ebner wrote:
> Should we also check in the create/update API calls for syntactic
> duplicates and fail the call? E.g. I can successfully issue:
> pvesh set /storage/foo --content-dirs backup=bar,iso=bar
> and only get the error later during activation.
Not allowing users to configure `content-dirs` with syntactic duplicates
sounds good to me (it wouldn't catch situations involving symlinks, but
those require quite some manual hacking from the user's side anyway).
As this would be mostly a convenience feature, I'd send a patch after
next week if that's okay.
next prev parent reply other threads:[~2023-06-07 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 17:03 Friedrich Weber
2023-06-06 15:28 ` [pve-devel] applied: " Thomas Lamprecht
2023-06-07 7:46 ` Friedrich Weber
2023-06-07 10:01 ` [pve-devel] " Fiona Ebner
2023-06-07 10:18 ` Friedrich Weber [this message]
2023-06-07 10:35 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4855967b-49f1-1de1-d79c-a03600c503ed@proxmox.com \
--to=f.weber@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal