From: Christian Ebner <c.ebner@proxmox.com>
To: Lucas Barros <lucasbarros.kam@gmail.com>, pbs-devel@lists.proxmox.com
Subject: Re: [PATCH proxmox] fix #8127: notify: matcher: fix description of match-calendar
Date: Mon, 9 Nov 2026 12:58:09 +0100 [thread overview]
Message-ID: <47adafa0-e437-4cbb-b7ea-84291e6baa59@proxmox.com> (raw)
In-Reply-To: <20261107223522.23169-1-lucasbarros.kam@gmail.com>
On 11/7/26 11:35 PM, Lucas Barros wrote:
> The doc comment of the 'match-calendar' property was copied from
> 'match-severity', so the API schema, and with it the CLI help and the
> man page of 'proxmox-backup-manager notification matcher create' and
> 'update', describes it as a list of matched severity levels. The
> option matches the timestamp of a notification against calendar
> entries, though.
>
> Use a description that fits what the option does.
>
> Signed-off-by: Lucas Barros <lucasbarros.kam@gmail.com>
Thanks for your contribution.
Tested that the correct string is now shown in docs and return type in
API viewer.
Acked-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
prev parent reply other threads:[~2026-11-09 11:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 22:35 [PATCH proxmox] fix #8127: notify: matcher: fix description of match-calendar Lucas Barros
2026-11-09 11:58 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47adafa0-e437-4cbb-b7ea-84291e6baa59@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=lucasbarros.kam@gmail.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.