From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 7852F1FF09B for ; Mon, 09 Nov 2026 12:58:14 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8ACC420CE2; Mon, 09 Nov 2026 12:58:13 +0100 (CET) Message-ID: <47adafa0-e437-4cbb-b7ea-84291e6baa59@proxmox.com> Date: Mon, 9 Nov 2026 12:58:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox] fix #8127: notify: matcher: fix description of match-calendar To: Lucas Barros , pbs-devel@lists.proxmox.com References: <20261107223522.23169-1-lucasbarros.kam@gmail.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20261107223522.23169-1-lucasbarros.kam@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794225489741 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.435 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 34SIWQBFK56ZTO6NIBZR6HJDGQWRXNMK X-Message-ID-Hash: 34SIWQBFK56ZTO6NIBZR6HJDGQWRXNMK X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 11/7/26 11:35 PM, Lucas Barros wrote: > The doc comment of the 'match-calendar' property was copied from > 'match-severity', so the API schema, and with it the CLI help and the > man page of 'proxmox-backup-manager notification matcher create' and > 'update', describes it as a list of matched severity levels. The > option matches the timestamp of a notification against calendar > entries, though. > > Use a description that fits what the option does. > > Signed-off-by: Lucas Barros Thanks for your contribution. Tested that the correct string is now shown in docs and return type in API viewer. Acked-by: Christian Ebner Tested-by: Christian Ebner