Re: [pve-devel] [PATCH manager 6/6] ui: cluster backup: use cluster-wide storage selector

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 06.09.21 13:32, Fabian Ebner wrote:
> adapted from the existing storage selector.
> 
> Previously, only the storages for the local node would be shown, which
> prevented configuring a job for remote nodes when the storage is not
> available on the local node.
> 
> In contrast to the existing storage selector, no usage information is
> displayed. It's not readily available, and while it could be extracted
> from the global resource store, that's a bit messy, and in case a
> local storage is available on multiple nodes, there are multiple
> values to deal with. Instead, show the list of nodes where the storage
> is available and whether it is shared, which is relevant when seen
> from a cluster perspective.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/Makefile                       |  1 +
>  www/manager6/dc/Backup.js                   |  5 +-
>  www/manager6/form/ClusterStorageSelector.js | 96 +++++++++++++++++++++
>  3 files changed, 99 insertions(+), 3 deletions(-)
>  create mode 100644 www/manager6/form/ClusterStorageSelector.js
> 

not to happy with that one in regards to code reuse.

We either need to make this the parent of the node-specific one and hide combo-grid
columns depending on settings, or vice versa (this extends from the single one).
The former seems a bit more intuitive to me from a quick check, but no hard feelings
on that..