From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager] pve7to8: reword and fix typos in description
Date: Mon, 22 Apr 2024 14:12:45 +0200 [thread overview]
Message-ID: <46ba4aee-093e-4024-ae15-6e21c2d1a4ca@proxmox.com> (raw)
In-Reply-To: <20240419163345.263086-1-a.zeidler@proxmox.com>
Am 19.04.24 um 18:33 schrieb Alexander Zeidler:
> diff --git a/bin/Makefile b/bin/Makefile
> index 180a91b5..6c5f9b14 100644
> --- a/bin/Makefile
> +++ b/bin/Makefile
> @@ -66,10 +66,10 @@ pve6to7.1:
>
> pve7to8.1:
> printf ".TH PVE7TO8 1\n.SH NAME\npve7to8 \- Proxmox VE upgrade checker script for 7.4+ to current 8.x\n" > $@.tmp
> - printf ".SH DESCRIPTION\nThis tool will help you to detect common pitfalls and misconfguration\
> - before, and during the upgrade of a Proxmox VE system\n" >> $@.tmp
> - printf "Any failure must be addressed before the upgrade, and any waring must be addressed, \
> - or at least carefully evaluated, if a false-positive is suspected\n" >> $@.tmp
> + printf ".SH DESCRIPTION\nThis tool will help you detect common pitfalls and misconfigurations\
> + before and during the upgrade of a Proxmox VE system.\n" >> $@.tmp
> + printf "Any failures or warnings must be addressed prior to the upgrade.\n" >> $@.tmp
Nit: "All failures and warnings" sounds slightly better IMHO
> + printf "If you think that a message is a false-positive for your setup, double-check that before proceeding.\n" >> $@.tmp
The old wording was a bit stronger:
- with the new wording, failures and warnings are put into the same bucket
- I do like the "carefully evaluated" more than a simple "double-check"
> printf ".SH SYNOPSIS\npve7to8 [--full]\n" >> $@.tmp
> mv $@.tmp $@
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-04-22 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 16:33 Alexander Zeidler
2024-04-22 12:12 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46ba4aee-093e-4024-ae15-6e21c2d1a4ca@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal