all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Stefan Reiter <s.reiter@proxmox.com>
Subject: [pbs-devel] applied: [PATCH v2 backup 2/2] add .../apt/update API call
Date: Thu, 23 Jul 2020 10:42:16 +0200	[thread overview]
Message-ID: <46b82bbe-7e00-0482-0708-bd394d1ec32a@proxmox.com> (raw)
In-Reply-To: <20200721114108.11603-2-s.reiter@proxmox.com>

On 21.07.20 13:41, Stefan Reiter wrote:
> Depends on patched apt-pkg-native-rs. Changelog-URL detection is
> inspired by PVE perl code for now, though marked with fixme to use 'apt
> changelog' later on, if/when our repos have APT-compatible changelogs
> set up.
> 
> list_installed_apt_packages iterates all packages and creates an
> APTUpdateInfo with detailed information for every package matched by the
> given filter Fn.
> 
> Sadly, libapt-pkg has some questionable design choices regarding their
> use of 'iterators', which means quite a bit of nesting...
> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> 
> v2:
> * Include feedback from Fabian:
> ** Update Cargo.toml with now packaged apt-pkg-native (still no update on my PR)
> ** Use proxmox.com changelog logic for all origin=Proxmox packages, not just pbs
> ** Change serde naming to PascalCase for APTUpdateInfo
> ** Add FIXME to changelog detection
> ** Update comments
> 
> 
>  Cargo.toml           |   1 +
>  src/api2/node.rs     |   2 +
>  src/api2/node/apt.rs | 211 +++++++++++++++++++++++++++++++++++++++++++
>  src/api2/types.rs    |  27 ++++++
>  4 files changed, 241 insertions(+)
>  create mode 100644 src/api2/node/apt.rs
> 
>

applied, thanks! Adding additionally the POST call on it for `apt-get update` wouldn't
have been really more work ;)




  reply	other threads:[~2020-07-23  8:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 11:41 [pbs-devel] [PATCH backup 1/2] move subscription API path to /nodes Stefan Reiter
2020-07-21 11:41 ` [pbs-devel] [PATCH v2 backup 2/2] add .../apt/update API call Stefan Reiter
2020-07-23  8:42   ` Thomas Lamprecht [this message]
2020-07-21 17:36 ` [pbs-devel] applied: [PATCH backup 1/2] move subscription API path to /nodes Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46b82bbe-7e00-0482-0708-bd394d1ec32a@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    --cc=s.reiter@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal