all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
	<pbs-devel@lists.proxmox.com>,
	Hannes Laimer <h.laimer@proxmox.com>
Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/3] add system report
Date: Wed, 4 Nov 2020 08:49:16 +0100	[thread overview]
Message-ID: <46840914-1924-6650-ebee-7b2f730ed51b@proxmox.com> (raw)
In-Reply-To: <20201103122908.114524-1-h.laimer@proxmox.com>

On 03.11.20 13:29, Hannes Laimer wrote:
> Adds api endpoint, webui element and cli command for system report generation.
> Changing the information the report includes should be straight forward(in server/report.rs),
> it is possible to specify files, commands and function calls that should
> be included in the report.
> 
> Hannes Laimer (3):
>   report: add api endpoint and function to generate report
>   report: add webui button for system report
>   manager: add report cli command
> 
>  src/api2/node.rs                  |  2 +
>  src/api2/node/report.rs           | 35 ++++++++++++++
>  src/bin/proxmox-backup-manager.rs | 18 ++++++++
>  src/server.rs                     |  3 ++
>  src/server/report.rs              | 77 +++++++++++++++++++++++++++++++
>  www/Subscription.js               | 75 +++++++++++++++++++++++++++++-
>  6 files changed, 209 insertions(+), 1 deletion(-)
>  create mode 100644 src/api2/node/report.rs
>  create mode 100644 src/server/report.rs
> 



applied series, thanks! FYI, I did some additions on top:
 
* lsblk's argument for ASCII output needs two dashes, --ascii vs. -ascii

* just use the method in manager CLIU command directly, we do not win anything
  here by letting it connected to the API, also, it could hurt if a case has
  issues with said API daemon - they may not be able to get the report anymore
  for our enterprise support.

* added some more commands and configs, like ZFS related ones for example.





      parent reply	other threads:[~2020-11-04  7:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03 12:29 [pbs-devel] " Hannes Laimer
2020-11-03 12:29 ` [pbs-devel] [PATCH proxmox-backup 1/3] report: add api endpoint and function to generate report Hannes Laimer
2020-11-03 12:29 ` [pbs-devel] [PATCH proxmox-backup 2/3] report: add webui button for system report Hannes Laimer
2020-11-03 12:29 ` [pbs-devel] [PATCH proxmox-backup 3/3] manager: add report cli command Hannes Laimer
2020-11-04  7:49 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46840914-1924-6650-ebee-7b2f730ed51b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal