From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH manager] ui: tree: show tooltips for all entries that have sensible information
Date: Fri, 15 Nov 2024 07:37:47 +0100 [thread overview]
Message-ID: <462e7e0d-e5b5-4af7-a0f5-6c59d6482dac@proxmox.com> (raw)
In-Reply-To: <095563a0-f251-4fe8-9573-a27f5bb06330@proxmox.com>
On 11/14/24 19:09, Thomas Lamprecht wrote:
> Am 14.11.24 um 09:04 schrieb Dominik Csapak:
>> instead of filtering pools and groups out manually, simply accumulate
>> the info we want to to have (status/hastate/etc.) and if any of those
>> exist, show the tooltip.
>>
>> This results in the nodes also having a tooltip, including their hastate
>> (such as online/maintenance), and automatically would show such things
>> in the future if we add those fields to other entries.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>> www/manager6/tree/ResourceTree.js | 11 +++++++----
>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>
>>
>
> applied, thanks!
>
> One minor thing I noticed, and where I'm rather unsure if we should do
> anything about it, is some potential odd interaction between the tooltip
> and the context menu, e.g. if I open the context menu of a node and then
> move the cursor up to the node icon the tooltip pops up and is displayed
> over the context menu and needs relatively long to hide.
> But FWICT this was always the case for guests already anyway, so probably
> it's just me overthinking this.
Yeah I also think this was always the case, and IMHO it's not a huge issue.
If we want to change that behavior, I'd suggest we disable the tree
tooltips completely as long as a context menu is shown, but this
can also be done later.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-15 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 8:04 [pve-devel] " Dominik Csapak
2024-11-14 18:09 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-15 6:37 ` Dominik Csapak [this message]
2024-11-15 7:08 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462e7e0d-e5b5-4af7-a0f5-6c59d6482dac@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.