all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH access-control/manager/network v5 0/6] fix #7294: pool: add SDN VNets as pool members
Date: Fri, 20 Nov 2026 08:48:29 +0100	[thread overview]
Message-ID: <46216150-0a14-46a5-94f0-184066c67ec1@proxmox.com> (raw)
In-Reply-To: <179515721895.2281522.9098172508007955674.b4-ty@b4>

Thanks for the follow up.

I'll take a closer look at your changes and the follow up commits you added
on top. I'll add the remaining "still open" items to my backlog.

On 11/20/26 8:42 AM, Thomas Lamprecht wrote:
> On Thu, 19 Nov 2026 13:47:25 +0100, David Riley wrote:
>> Maintainer Note:
>>
>> This patch requires version bumps:
>> * pve-access-control
>> * pve-manager
>> * pve-network
>>
>> [...]
> Applied, thanks!
>
> Tested adding, moving and removing VNet pool members on a three-node
> cluster.
>
> What I changed in your patches:
> - A member added while an SDN apply deleted or moved its VNet was missed
>    and stayed in the pool forever. Changes to network members now take
>    the SDN domain lock, so they can't overlap with an apply.
> - The API descriptions now explain the three member forms and that they
>    only control which network devices can be configured. I also made the
>    naming consistent and the dialog labels clearer.
> - The ID patterns now end with \z instead of $, so they no longer accept
>    a trailing newline (yeah, its a stupid design, I know...).
>
> What I added on top:
> - The pool index returned network members only by ID, while guests and
>    storages also have 'vmid' and 'storage'. Network members now get a
>    'network' property and a 'network/' ID prefix, to settle this before
>    the release.
> - pve-sdn-commit did not take the SDN domain lock at boot, so it could
>    clash with an apply or a pool change. It now does, and still applies
>    the config locally if that fails, but marks the unit as failed.
> - The user docs now cover VNets in pools.
>
> Still open:
> - The VNet member key is parsed in several places; a shared helper in
>    PVE::AccessControl might be nice.
> - The VLAN tag and propagate fields could be disabled for VNets that
>    aren't VLAN-aware.
> - The dialog offers VNets that aren't applied yet, but the API only
>    accepts applied ones.
>
> [pve-access-control]
> [1/6] rpcenv: allow SDN.Allocate to modify permissions on SDN paths
>       commit: 74748664eb8299e9b5d31fcbda04922b29a300f4
>
> [pve-manager]
> [4/6] ui: replace var with let to match style guide for variable declaration
>       commit: b9a0f503a4d1615c5956cb88c6f0df0470c9bbc8
> [5/6] fix #7294: api: pool: add SDN VNets as pool members
>       commit: 948e075031ca0705b3997f459fe619c22b222994
> [6/6] fix #7294: ui: pool: add SDN VNets as pool members
>       commit: 69ba33f18e31342c68cd395d56cdc4b5af340a0d
>
> [pve-network]
> [2/6] sdn: register api formats for zones and vnets
>       commit: 5016945a918c22e8b264f327511dc9afc9428567
> [3/6] fix #7294: sdn: vnet: update pool members on VNet zone change and deletion
>       commit: 27afd386382a00a187883c27bb8e358c1fd0c1e9




      reply	other threads:[~2026-11-20  7:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 12:47 [PATCH access-control/manager/network v5 0/6] fix #7294: pool: add SDN VNets as pool members David Riley
2026-11-19 12:47 ` [PATCH pve-access-control v5 1/6] rpcenv: allow SDN.Allocate to modify permissions on SDN paths David Riley
2026-11-19 12:47 ` [PATCH pve-network v5 2/6] sdn: register api formats for zones and vnets David Riley
2026-11-19 12:47 ` [PATCH pve-network v5 3/6] fix #7294: sdn: vnet: update pool members on VNet zone change and deletion David Riley
2026-11-19 12:47 ` [PATCH pve-manager v5 4/6] ui: replace var with let to match style guide for variable declaration David Riley
2026-11-19 12:47 ` [PATCH pve-manager v5 5/6] fix #7294: api: pool: add SDN VNets as pool members David Riley
2026-11-19 12:47 ` [PATCH pve-manager v5 6/6] fix #7294: ui: " David Riley
2026-11-20  7:42 ` [PATCH access-control/manager/network v5 0/6] fix #7294: " Thomas Lamprecht
2026-11-20  7:48   ` David Riley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46216150-0a14-46a5-94f0-184066c67ec1@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal