all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: David Riley <d.riley@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [PATCH pve-manager v5 4/6] ui: replace var with let to match style guide for variable declaration
Date: Thu, 19 Nov 2026 13:47:29 +0100	[thread overview]
Message-ID: <20261119124731.84602-5-d.riley@proxmox.com> (raw)
In-Reply-To: <20261119124731.84602-1-d.riley@proxmox.com>

No semantic change intended.

Signed-off-by: David Riley <d.riley@proxmox.com>
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Link: https://pve.proxmox.com/wiki/Javascript_Style_Guide#Variables
---
 www/manager6/grid/PoolMembers.js | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
index b0c9ccb3..69f50e30 100644
--- a/www/manager6/grid/PoolMembers.js
+++ b/www/manager6/grid/PoolMembers.js
@@ -13,7 +13,7 @@ Ext.define('PVE.pool.AddVM', {
     },
 
     initComponent: function () {
-        var me = this;
+        let me = this;
 
         if (!me.pool) {
             throw 'no pool specified';
@@ -23,7 +23,7 @@ Ext.define('PVE.pool.AddVM', {
         me.method = 'PUT';
         me.extraRequestParams.poolid = me.pool;
 
-        var vmsField = Ext.create('Ext.form.field.Text', {
+        let vmsField = Ext.create('Ext.form.field.Text', {
             name: 'vms',
             hidden: true,
             allowBlank: false,
@@ -32,7 +32,7 @@ Ext.define('PVE.pool.AddVM', {
         let basicFilter = (data) =>
             (data.type === 'lxc' || data.type === 'qemu') && data.pool !== me.pool;
 
-        var vmStore = Ext.create('Ext.data.Store', {
+        let vmStore = Ext.create('Ext.data.Store', {
             model: 'PVEResources',
             sorters: [
                 {
@@ -43,7 +43,7 @@ Ext.define('PVE.pool.AddVM', {
             filters: [(item) => basicFilter(item.data)],
         });
 
-        var vmGrid = Ext.create('widget.grid', {
+        let vmGrid = Ext.create('widget.grid', {
             store: vmStore,
             border: true,
             height: 480,
@@ -53,7 +53,7 @@ Ext.define('PVE.pool.AddVM', {
                 mode: 'SIMPLE',
                 listeners: {
                     selectionchange: function (model, selected, opts) {
-                        var selectedVms = [];
+                        let selectedVms = [];
                         selected.forEach(function (vm) {
                             selectedVms.push(vm.data.vmid);
                         });
@@ -127,7 +127,7 @@ Ext.define('PVE.pool.AddStorage', {
     extend: 'Proxmox.window.Edit',
 
     initComponent: function () {
-        var me = this;
+        let me = this;
 
         if (!me.pool) {
             throw 'no pool specified';
@@ -166,7 +166,7 @@ Ext.define('PVE.grid.PoolMembers', {
     stateId: 'grid-pool-members',
 
     initComponent: function () {
-        var me = this;
+        let me = this;
 
         if (!me.pool) {
             throw 'no pool specified';
@@ -193,7 +193,7 @@ Ext.define('PVE.grid.PoolMembers', {
             ],
         });
 
-        var coldef = PVE.data.ResourceStore.defaultColumns().filter(
+        let coldef = PVE.data.ResourceStore.defaultColumns().filter(
             (c) => c.dataIndex !== 'tags' && c.dataIndex !== 'lock',
         );
 
@@ -201,9 +201,9 @@ Ext.define('PVE.grid.PoolMembers', {
             me.rstore.load();
         };
 
-        var sm = Ext.create('Ext.selection.RowModel', {});
+        let sm = Ext.create('Ext.selection.RowModel', {});
 
-        var remove_btn = new Proxmox.button.Button({
+        let remove_btn = new Proxmox.button.Button({
             text: gettext('Remove'),
             disabled: true,
             selModel: sm,
@@ -214,7 +214,7 @@ Ext.define('PVE.grid.PoolMembers', {
                 );
             },
             handler: function (btn, event, rec) {
-                var params = { delete: 1, poolid: me.pool };
+                let params = { delete: 1, poolid: me.pool };
                 if (rec.data.type === 'storage') {
                     params.storage = rec.data.storage;
                 } else if (
@@ -254,7 +254,7 @@ Ext.define('PVE.grid.PoolMembers', {
                                 text: gettext('Virtual Machine'),
                                 iconCls: 'fa fa-desktop',
                                 handler: function () {
-                                    var win = Ext.create('PVE.pool.AddVM', { pool: me.pool });
+                                    let win = Ext.create('PVE.pool.AddVM', { pool: me.pool });
                                     win.on('destroy', reload);
                                     win.show();
                                 },
@@ -263,7 +263,7 @@ Ext.define('PVE.grid.PoolMembers', {
                                 text: gettext('Storage'),
                                 iconCls: 'fa fa-hdd-o',
                                 handler: function () {
-                                    var win = Ext.create('PVE.pool.AddStorage', { pool: me.pool });
+                                    let win = Ext.create('PVE.pool.AddStorage', { pool: me.pool });
                                     win.on('destroy', reload);
                                     win.show();
                                 },
@@ -280,7 +280,7 @@ Ext.define('PVE.grid.PoolMembers', {
             listeners: {
                 itemcontextmenu: PVE.Utils.createCmdMenu,
                 itemdblclick: function (v, record) {
-                    var ws = me.up('pveStdWorkspace');
+                    let ws = me.up('pveStdWorkspace');
                     ws.selectById(record.data.id);
                 },
                 activate: reload,
-- 
2.47.3





  parent reply	other threads:[~2026-11-19 12:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 12:47 [PATCH access-control/manager/network v5 0/6] fix #7294: pool: add SDN VNets as pool members David Riley
2026-11-19 12:47 ` [PATCH pve-access-control v5 1/6] rpcenv: allow SDN.Allocate to modify permissions on SDN paths David Riley
2026-11-19 12:47 ` [PATCH pve-network v5 2/6] sdn: register api formats for zones and vnets David Riley
2026-11-19 12:47 ` [PATCH pve-network v5 3/6] fix #7294: sdn: vnet: update pool members on VNet zone change and deletion David Riley
2026-11-19 12:47 ` David Riley [this message]
2026-11-19 12:47 ` [PATCH pve-manager v5 5/6] fix #7294: api: pool: add SDN VNets as pool members David Riley
2026-11-19 12:47 ` [PATCH pve-manager v5 6/6] fix #7294: ui: " David Riley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119124731.84602-5-d.riley@proxmox.com \
    --to=d.riley@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal