Re: [PATCH v6 proxmox-backup 12/18] client: don't poll terminated source in FixedChunkStream

[Christian Ebner <c.ebner@proxmox.com>]

On 2/17/26 11:01 AM, Christian Ebner wrote:
> On 2/10/26 4:06 PM, Robert Obkircher wrote:
>> Fix incorrect chunking when the input file is a pts character device
>> (stdin in an interactive terminal). Previously, the stream could
>> produce multiple smaller chunks from interactive input, and a single
>> Ctrl+D was not enough to terminate it. This was because a None from
>> the source resulted in Some partial chunk, but the next time the input
>> was polled again and it suddenly had more input.
>>
>> The documentation of Stream::poll_next clearly states that calling it
>> on a terminated stream may panic, block forever, or cause other kinds
>> of problems, so this should be fixed even it it appeared to work with
>> normal files.
>>
>> Using the fuse method or adding a FusedStream trait bound might be
>> nicer that seemed like a larger change compared to the boolean.
>>
>> Signed-off-by: Robert Obkircher <r.obkircher@proxmox.com>
> 
> Good catch! Same issue is however also present for the dynamic 
> ChunkStream, so the safeguard should be added for it as well!
> 
> That can however be done as followup patch if nothing else comes up for 
> these patches.

Disregard this comment, did not see the next patch, which already does this!