Re: [pve-devel] [PATCH common, widget-toolkit, manager v5 0/7] fix #3893: make bridge vids configurable

[Aaron Lauterer <a.lauterer@proxmox.com>]

sent a v6 
https://lore.proxmox.com/pve-devel/20241112092554.106723-1-a.lauterer@proxmox.com/T/#t

On  2024-10-02  15:11, Aaron Lauterer wrote:
> Since this version reworks a few things, especially in the logic, I
> dropped the r-b and t-b tags in some patches.
> 
> The following patch has been dropped as this is handled in the API call
> itself now.
> [PATCH common v4 3/7] inotify: interfaces: make sure bridge_vids use space as separator
> 
> There is now a new one (2/7) changing the check in the iNotify.pm file
> slightly.
> 
> this version reworks a few parts since
> v4: incorporated @fionas suggestions, besides some style nits:
> * rename check_list_empty to list_is_empty and adapt the return values
> * renamed $check_vid to $valid_vid with return values for each case
> * switch list separators to spaces in the API call, instead of when
>    writing the file
> * rework small logical error in the check if the end VLAN ID is larger
>    than the start and $noerr is set.
> 
> v3: incorporated @shannons recommendations, in detail:
> * improve regex with non-capturing group
> * reworked check if valid VLAN config in UI field check
> * small code style and spelling things
> * reworded UI explanation text for bridge vids
> 
> v2:
> * renamed format in JSONSchema to a more generic `pve-vlan-id-or-range`
> * explicitly use spaces when writing interfaces file. This is one
>    possible approach to deal with the fact, that the generic `-list`
>    format will accept quite a few delimiters and we need spaces.
> * code style improvements such as naming the regex results.
> * add parameter verification to the web ui
> 
> With the changes to the JSONSchema we can then work on using it too for
> the guest trunk option. This hasn't been started yet though.
> 
> common: Aaron Lauterer (3):
>    tools: add check_list_empty function
>    inotify: interfaces: check if bridge_vids is truthy instead of defined
>    fix #3893: network: add vlan id and range parameter definitions
> 
>   src/PVE/INotify.pm    |  2 +-
>   src/PVE/JSONSchema.pm | 39 +++++++++++++++++++++++++++++++++++++++
>   src/PVE/Tools.pm      |  8 ++++++++
>   3 files changed, 48 insertions(+), 1 deletion(-)
> 
> 
> widget-toolkit: Aaron Lauterer (2):
>    fix #3892: Network: add bridge vids field for bridge_vids
>    Network: add explanation for bridge vids field
> 
>   src/node/NetworkEdit.js | 73 +++++++++++++++++++++++++++++++++++++++++
>   src/node/NetworkView.js |  5 +++
>   2 files changed, 78 insertions(+)
> 
> 
> manager: Aaron Lauterer (2):
>    fix #3893: api: network: add bridge_vids parameter
>    fix #3893: ui: network: enable bridge_vids field
> 
>   PVE/API2/Network.pm         | 23 ++++++++++++++++++++++-
>   www/manager6/node/Config.js |  1 +
>   2 files changed, 23 insertions(+), 1 deletion(-)
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel