Re: [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard

[Lorenz Stechauner <l.stechauner@proxmox.com>]

Hi,

tested this series a bit. everything seems to work as advertised, except 
the VM creation wizard. After submitting I get an error:

Parameter verification failed. (400)
textfield-4006-inputEl: property is not defined in schema and the schema 
does not allow additional properties

other small detail: width of the Bus/Device field for the bus nr. is too 
short to display two digit numbers.

On 20.09.21 14:23, Dominik Csapak wrote:
> this series is intended to replace dominics and my previous attempts
> at this [0][1][2]
>
> splits the bandwidth options into their on tab on the disk panel and
> introduces a 'MultiHDEdit' panel which creates/deletes the
> HDEdit panels on demand.
>
> The UX is modeled after Dominics first attempt, but a very different
> approach code-wise. instead of having a seperate 'data' panel that
> contains the vm config, let the multi disk panel handle that
> and pass it through to the panels below. this way the HDEdit does
> not need a big code-change to get/set the config.
>
> 0: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048690.html
> 1: https://lists.proxmox.com/pipermail/pve-devel/2021-July/049295.html
> 2: https://lists.proxmox.com/pipermail/pve-devel/2021-September/050013.html
>
> Dominik Csapak (10):
>    ui: qemu/HDEdit: move Bandwidth options to a different tab
>    ui: form/ControllerSelector: set correct max value for the device-id
>    ui: refactor sortByPreviousUsage and nextFreeDisk
>    ui: form/ControllerSelector: add updateVMConfig and getConfId
>    ui: qemu/HDEdit: use me instead of this
>    ui: qemu/HDEdit: fire an event when the disk id changes
>    ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets
>    ui: Utils: add capture group for the id in bus_match
>    ui: form/ControllerSelector: add option for selecting free on inital
>      config
>    ui: add qemu/MultiHDEdit and use it in the wizard
>
>   www/manager6/Makefile                   |   1 +
>   www/manager6/Utils.js                   |  48 +++-
>   www/manager6/form/ControllerSelector.js |  65 +++---
>   www/manager6/qemu/CreateWizard.js       |   4 +-
>   www/manager6/qemu/HDEdit.js             | 143 ++++++++----
>   www/manager6/qemu/MultiHDEdit.js        | 291 ++++++++++++++++++++++++
>   www/manager6/qemu/OSTypeEdit.js         |   2 +-
>   www/manager6/window/Wizard.js           |   5 +-
>   8 files changed, 477 insertions(+), 82 deletions(-)
>   create mode 100644 www/manager6/qemu/MultiHDEdit.js
>