[PATCH proxmox-backup] datastore: don't skip empty namespaces on s3 refresh

[PATCH proxmox-backup] datastore: don't skip empty namespaces on s3 refresh

[Hannes Laimer]

Without this empty namespaces present on s3 won't be visible locally.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
 pbs-datastore/src/datastore.rs | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index 7ad3d917..4749319a 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -2535,6 +2535,15 @@ impl DataStore {
                     format!("failed to strip store context prefix {store_prefix} for {object_key}")
                 })?;
                 if object_path.ends_with(NAMESPACE_MARKER_FILENAME) {
+                    // Ensure the marker's parent directory exists so the namespace is visible locally
+                    let ns_dir = tmp_base.join(object_path);
+                    if let Some(parent) = ns_dir.parent() {
+                        proxmox_sys::fs::create_path(
+                            parent,
+                            Some(dir_create_options),
+                            Some(dir_create_options),
+                        )?;
+                    }
                     continue;
                 }
 
-- 
2.47.3

Re: [PATCH proxmox-backup] datastore: don't skip empty namespaces on s3 refresh

[Christian Ebner]

Thanks for fixing this issue!

On 3/4/26 11:39 AM, Hannes Laimer wrote:
> Without this empty namespaces present on s3 won't be visible locally.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>

Tested by creating an (nested as well as root) empty namespace for a 
datastore backed by s3 and performing an s3 refresh. With the patch 
applied the namespace folder structure is created with ownership and 
permissions as expected.

Non empty namespaces did not suffer the issue, but still work as 
expected as well.

Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>