all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager/network v2 0/2] do not apply FRR configuration when reloading host network configuration
Date: Mon, 4 Aug 2025 18:45:16 +0200	[thread overview]
Message-ID: <4538806b-38c0-4900-9c0c-231e9bc378b9@proxmox.com> (raw)
In-Reply-To: <20250804140152.423614-1-s.hanreich@proxmox.com>

Am 04.08.25 um 16:01 schrieb Stefan Hanreich:
> The FRR apply function was called when omitting the skip_frr parameter, which is
> the case when saving the host network configuration via the Web UI, leading to
> an enabled FRR daemon after saving the network configuration.
> 
> In a follow-up we should also consider checking if the previous configuration
> contained FRR entities, but the new one doesn't and disable the FRR daemon in
> this case.
> 
> Changes from v1 to v2:
> * rebase on top of current master
> 
> pve-manager:
> 
> Stefan Hanreich (1):
>   api: network: default to not regenerating the frr configuration
> 
>  PVE/API2/Network.pm | 7 ++++---
>  bin/pve-sdn-commit  | 4 ++--
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> 
> pve-network:
> 
> Stefan Hanreich (1):
>   sdn: api: rename parameter from skip-frr to regenerate-frr
> 
>  src/PVE/API2/Network/SDN.pm | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> 
> Summary over all repositories:
>   3 files changed, 10 insertions(+), 11 deletions(-)
> 


applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      parent reply	other threads:[~2025-08-04 16:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-04 14:01 [pve-devel] " Stefan Hanreich
2025-08-04 14:01 ` [pve-devel] [PATCH pve-manager v2 1/1] api: network: default to not regenerating the frr configuration Stefan Hanreich
2025-08-04 14:01 ` [pve-devel] [PATCH pve-network v2 1/1] sdn: api: rename parameter from skip-frr to regenerate-frr Stefan Hanreich
2025-08-04 14:09 ` [pve-devel] [PATCH manager/network v2 0/2] do not apply FRR configuration when reloading host network configuration Friedrich Weber
2025-08-04 16:45 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4538806b-38c0-4900-9c0c-231e9bc378b9@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal