[pve-devel] [PATCH v2 installer] warn if maxvz is set <= 4 GiB

[pve-devel] [PATCH v2 installer] warn if maxvz is set <= 4 GiB

[Mira Limbeck]

If it is set and 0, don't warn.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---
v2:
 - added check != 0
 - fixed punctuation in text

 Proxmox/Install.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index c64e1d4..e278917 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -555,6 +555,10 @@ sub create_lvm_volumes {
 	my $maxvz = Proxmox::Install::Config::get_maxvz();
 	if ($iso_env->{product} eq 'pve' && !defined($maxvz)) {
 	    Proxmox::UI::message("Skipping auto-creation of LVM thinpool for guest data due to low space.");
+	} elsif ($iso_env->{product} eq 'pve' && $maxvz != 0) {
+	    Proxmox::UI::message(
+		"Skipping auto-creation of LVM thinpool for guest data. Maximum data volume size set too low."
+	    );
 	}
 	$datadev = undef;
     }
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH v2 installer] warn if maxvz is set <= 4 GiB

[Thomas Lamprecht]

Am 19.11.24 um 12:12 schrieb Mira Limbeck:
> If it is set and 0, don't warn.
> 
> Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
> ---
> v2:
>  - added check != 0
>  - fixed punctuation in text
> 
>  Proxmox/Install.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
>

applied, with a bit more context in commit subject, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel