From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied: [PATCH common 2/2] cgroup: get mode by checking /sys/fs/cgroup mount point
Date: Wed, 21 Sep 2022 10:05:06 +0200 [thread overview]
Message-ID: <44675499-d0a9-e463-394b-4481357f8938@proxmox.com> (raw)
In-Reply-To: <20220921075313.65674-2-w.bumiller@proxmox.com>
Am 21/09/2022 um 09:53 schrieb Wolfgang Bumiller:
> Since even in pure unified layouts there may be a
> `name=systemd` v1 cgroup mounted additionally (manually or
> potentially via systemd-nspawn apparently), we should check
> what's actually mounted at `/sys/fs/cgroup` rather than
> whether v1 cgroups exist.
>
> Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
> ---
> src/PVE/CGroup.pm | 27 ++++++++++++++++++---------
> 1 file changed, 18 insertions(+), 9 deletions(-)
>
>
applied, thanks!
> + my $mounts = PVE::ProcFSTools::parse_proc_mounts();
> + for my $entry (@$mounts) {
> + my ($what, $dir, $fstype, $opts) = @$entry;
style nit: we nowadays try to use $foo->@* for new additions, but really no hard
feelings so I kept it as is.
next prev parent reply other threads:[~2022-09-21 8:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 7:53 [pve-devel] [PATCH common 1/2] cgroup: make get_v1_controllers private Wolfgang Bumiller
2022-09-21 7:53 ` [pve-devel] [PATCH common 2/2] cgroup: get mode by checking /sys/fs/cgroup mount point Wolfgang Bumiller
2022-09-21 8:05 ` Thomas Lamprecht [this message]
2022-09-21 8:03 ` [pve-devel] applied: [PATCH common 1/2] cgroup: make get_v1_controllers private Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44675499-d0a9-e463-394b-4481357f8938@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.