[pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type

[pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type

[Mira Limbeck]

and encode the username:password string as base64 [0]. This fixes the
error 407 issue when using proxy authentication [1].


[0] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Proxy-Authorization
[1] https://forum.proxmox.com/threads/checking-the-subscription-behind-a-proxy-fails.112063/

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
---
 proxmox-http/src/client/connector.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-http/src/client/connector.rs b/proxmox-http/src/client/connector.rs
index d6ba9dd..f3e7535 100644
--- a/proxmox-http/src/client/connector.rs
+++ b/proxmox-http/src/client/connector.rs
@@ -184,8 +184,8 @@ impl hyper::service::Service<Uri> for HttpsConnector {
                     if let Some(authorization) = authorization {
                         let _ = write!(
                             connect_request,
-                            "Proxy-Authorization: {}\r\n",
-                            authorization
+                            "Proxy-Authorization: Basic {}\r\n",
+                            base64::encode(authorization)
                         );
                     }
                     let _ = write!(connect_request, "Host: {0}:{1}\r\n\r\n", host, port);
-- 
2.30.2

[pbs-devel] applied: [PATCH proxmox-http] http: fix proxy authorization header to include type

[Wolfgang Bumiller]

applied, thanks

Re: [pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type

[Thomas Lamprecht]

Am 20/07/2022 um 16:20 schrieb Mira Limbeck:
> and encode the username:password string as base64 [0]. This fixes the
> error 407 issue when using proxy authentication [1].

does this break setups that configured "Basic base64-encoded-pw" themselves though,
or was that never possible (e.g., due to schema not allowing that)?

Re: [pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type

[Wolfgang Bumiller]

On Thu, Jul 21, 2022 at 01:32:32PM +0200, Thomas Lamprecht wrote:
> Am 20/07/2022 um 16:20 schrieb Mira Limbeck:
> > and encode the username:password string as base64 [0]. This fixes the
> > error 407 issue when using proxy authentication [1].
> 
> does this break setups that configured "Basic base64-encoded-pw" themselves though,
> or was that never possible (e.g., due to schema not allowing that)?

That would break other things. Eg. `ProxyConfig;:to_proxy_string` uses
it to build "http://<authorization>@<host>" strings, so the "Basic "
prefix and base64 encoding would break those.

However, we also build such headers in src/client/simple.rs which should
will need the same change I suppose?

Re: [pbs-devel] [PATCH proxmox-http] http: fix proxy authorization header to include type

[Mira Limbeck]

On 7/21/22 13:46, Wolfgang Bumiller wrote:
> On Thu, Jul 21, 2022 at 01:32:32PM +0200, Thomas Lamprecht wrote:
>> Am 20/07/2022 um 16:20 schrieb Mira Limbeck:
>>> and encode the username:password string as base64 [0]. This fixes the
>>> error 407 issue when using proxy authentication [1].
>> does this break setups that configured "Basic base64-encoded-pw" themselves though,
>> or was that never possible (e.g., due to schema not allowing that)?
> That would break other things. Eg. `ProxyConfig;:to_proxy_string` uses
> it to build "http://<authorization>@<host>" strings, so the "Basic "
> prefix and base64 encoding would break those.
>
> However, we also build such headers in src/client/simple.rs which should
> will need the same change I suppose?

Do we want to make the authentication scheme, here `Basic`, configurable?