all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage] nfs: check connection: support NFSv4-only servers without rpcbind
Date: Tue, 24 Jan 2023 17:18:35 +0100	[thread overview]
Message-ID: <43b9ee9f-1232-344e-4acc-b304824d30bd@proxmox.com> (raw)
In-Reply-To: <20230123091450.58359-1-f.ebner@proxmox.com>

Am 23/01/2023 um 10:14 schrieb Fiona Ebner:
> by simply doing a ping with the expected port as a fallback when the
> rpcinfo command fails.
> 
> The timeout was chosen to be 2 seconds, because that's what the
> existing callers of tcp_ping() in the iSCSI and GlusterFS plugins use.
> 
> Alternatively, the existing check could be replaced, but that would
> 1. Dumb down the check.
> 2. Risk breakage in some corner case that's yet to be discovered.
> 3. It would still be necessary to use rpcinfo (or dumb the check down
> even further) in case port=0; from 'man 5 nfs' about the NFSv4 'port'
> option:
>> If the specified port value is 0, then the NFS client uses the NFS
>> service port number advertised by the server's rpcbind service.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/118466/post-524449
> https://forum.proxmox.com/threads/120774/
> 
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>  PVE/Storage/NFSPlugin.pm | 14 +++++++++++++-
>  1 file changed, 13 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




      reply	other threads:[~2023-01-24 16:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23  9:14 [pve-devel] " Fiona Ebner
2023-01-24 16:18 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43b9ee9f-1232-344e-4acc-b304824d30bd@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal