From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox-backup v3] api: make prune-group a real workertask
Date: Tue, 9 Apr 2024 12:44:24 +0200 [thread overview]
Message-ID: <43ae0253-3e7f-45d7-ab3b-ec543f3fcc66@proxmox.com> (raw)
In-Reply-To: <20240308133625.32282-1-g.goller@proxmox.com>
Am 08/03/2024 um 14:36 schrieb Gabriel Goller:
> `prune-group` is currently not a real workertask, ie it behaves like one
> but doesn't start a thread nor a task to do its work.
>
> Changed it to start a tokio-task, so that we can delete snapshots
> asynchronously. The `dry-run` feature still behaves in the same way and
> returns early.
>
> This paves the way for the new logging infra (which uses `task_local` to
> define a logger) and improves performance of bigger backup-groups.
>
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>
> v3, thanks @Max
> * remove use-task parameter, extract from serde Value
> * simplify dry-run statement
> * removed prune-result output
> * inline variables in formatting call
>
> v2, thanks @Fiona, @Thomas:
> * use feature flag to activate, so we don't break the api
> * convert the result to a structure and print it in the tasklog
> * enable the feature flag in the frontend
>
>
> src/api2/admin/datastore.rs | 152 ++++++++++++++++++++++--------------
> www/datastore/Prune.js | 1 +
> 2 files changed, 96 insertions(+), 57 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2024-04-09 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 13:36 [pbs-devel] " Gabriel Goller
2024-03-12 10:30 ` Stefan Lendl
2024-03-12 13:07 ` Gabriel Goller
2024-04-02 11:14 ` Stefan Lendl
2024-04-09 9:04 ` Gabriel Goller
2024-04-09 10:44 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ae0253-3e7f-45d7-ab3b-ec543f3fcc66@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal