From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH v3 container] fix invalid device passthrough being added to config
Date: Tue, 16 Apr 2024 12:56:33 +0200 [thread overview]
Message-ID: <42c7fdd9-76f8-4c18-ac38-d711312c5f90@proxmox.com> (raw)
In-Reply-To: <2dc344e6-2ec4-407a-b627-2ea83ae48005@proxmox.com>
Am 16.04.24 um 12:47 schrieb Fiona Ebner:
> Am 16.04.24 um 11:27 schrieb Filip Schauer:
>> diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
>> index 5ac1446..408140f 100644
>> --- a/src/PVE/LXC/Config.pm
>> +++ b/src/PVE/LXC/Config.pm
>> @@ -3,7 +3,8 @@ package PVE::LXC::Config;
>> use strict;
>> use warnings;
>>
>> -use Fcntl qw(O_RDONLY);
>> +use Errno qw(ENOENT);
>> +use Fcntl qw(O_RDONLY :mode);
>>
>> use PVE::AbstractConfig;
>> use PVE::Cluster qw(cfs_register_file);
>
> I dropped the above hunk, because it's a left-over from a previous
> version AFAICT.
>
And the LXC::Config module did not yet include LXC::Tools, added that
with a follow-up patch.
prev parent reply other threads:[~2024-04-16 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 9:27 [pve-devel] " Filip Schauer
2024-04-16 10:47 ` [pve-devel] applied: " Fiona Ebner
2024-04-16 10:56 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42c7fdd9-76f8-4c18-ac38-d711312c5f90@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.