Re: [pmg-devel] [PATCH pmg-api/pmg-gui v3]

[Friedrich Weber <f.weber@proxmox.com>]

Thanks for the v3!

On 19/02/2025 13:18, Stoiko Ivanov wrote:
> This series replaces two previous patch-series.
> 
> v2->v3:
> for the content-type matching based on magic infromation only two patches
> were added that remove the fallback on the content-type header in case no
> filetype could be found through magic.
> The one place were I decided to fall back on header information was when
> determining if a mime-part is an archive.
> 
> places where the content-type information was used are based on grepping
> for PMX_ in the pmg-api sources.
> 
> Tested with Friedrich's swaks reproducer - the random blob was not
> detected as pdf anymore.

I tested this again with the reproducer from v2 -- seems to work as I'd
expect now!

> no changes to the series for matching headers only on the top-part
> (resending so that the comment that it's based on v2 of the content-type
> series does not cause confusion)

I also tested the `top-part-only` option, works as I'd expect.

One nit for 3/5 sent separately, apart from that I didn't encounter any
issues:

Tested-by: Friedrich Weber <f.weber@proxmox.com>




_______________________________________________
pmg-devel mailing list
pmg-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pmg-devel