From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Tschlatscher <d.tschlatscher@proxmox.com>
Subject: Re: [pve-devel] [PATCH v6 manager] ui: vm network: allow to override MTU for virtio devices
Date: Tue, 8 Nov 2022 17:47:08 +0100 [thread overview]
Message-ID: <41e61c00-ffa8-f4e9-fc35-dc13bae93b2e@proxmox.com> (raw)
In-Reply-To: <56868828-dac3-945a-c3af-d2fcf32bc2f7@proxmox.com>
Am 12/10/2022 um 10:57 schrieb Daniel Tschlatscher:
> This patch still applies well and works as intended.
>
> There is one UI suggestion inline.
>
>
> Tested-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
>
thx!
>> @@ -161,6 +187,14 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
>> value: '',
>> allowBlank: true,
>> },
>> + {
>> + xtype: 'displayfield',
>> + userCls: 'pmx-hint',
>> + value: gettext("Use the special value '1' to inherit the MTU value from the underlying bridge"),
>> + bind: {
>> + hidden: '{!showMtuHint}',
>> + },
>> + },
> I think it might make a bit more sense to move this into the
> advancedColumn1 as well, as now it is displayed in the opposite column,
> which makes the UI flow kind of confusing.
> Perhaps an even better option though, would be to move the displayfield
> into an advancedColumnB, which would also remove the line width limit
> and with it the somewhat ugly line break.
>
With Oguz not working here anymore, would you like to re-send this with that
change?
prev parent reply other threads:[~2022-11-08 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 8:03 Oguz Bektas
2022-10-12 8:57 ` Daniel Tschlatscher
2022-11-08 16:47 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41e61c00-ffa8-f4e9-fc35-dc13bae93b2e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.tschlatscher@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal