From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC PATCH widget-toolkit] utils: API2Request: defer masking after layout
Date: Tue, 19 Mar 2024 09:09:11 +0100 [thread overview]
Message-ID: <4196395c-95cc-4a8d-9d2b-1049b233d41a@proxmox.com> (raw)
In-Reply-To: <ce64a586-31c9-4786-b507-3344bcecd00f@proxmox.com>
>>> sending as RFC because i'm unsure if we accidentally broke the masking
>>> somewhere along the way. AFAICS from the current code, this never could have
>>> worked properly? anyway, i'll be looking into that sometimes soon, and
>>> this patch should be correct anyway...
>>
>> it surely did sometimes in the past, maybe ExtJS 7?
>
>
> yeah maybe, I'll see if i can find out when it still worked and why..
> could also be general browser behavior change though
>
so tested back to pve 5 and the behaviour is still the same on chrome/firefox.
my guess is simply either changed browser behaviour or we missed that for much
longer than i thought...
next prev parent reply other threads:[~2024-03-19 8:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-18 13:44 Dominik Csapak
2024-03-18 15:50 ` Thomas Lamprecht
2024-03-19 7:44 ` Dominik Csapak
2024-03-19 8:09 ` Dominik Csapak [this message]
2024-03-19 8:21 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4196395c-95cc-4a8d-9d2b-1049b233d41a@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.