From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit 3/3] fix #3892: NetworkEdit: add bridge vids field for bridge_vids
Date: Wed, 7 Jun 2023 18:12:59 +0200 [thread overview]
Message-ID: <402ddaae-88d5-c0bc-2ae2-813a36130ff7@proxmox.com> (raw)
In-Reply-To: <6c903c4b-e105-5063-118c-882d7df2cbc9@proxmox.com>
Am 02/06/2023 um 15:10 schrieb Aaron Lauterer:
> What about safeguarding the vids to only be added/used if we are on PVE?
> Something like `if (PVE) {`?
We normally use config flags and set them only in those products that support
this, that would be a bit cleaner than `typeof PVE === "object"` or the like.
next prev parent reply other threads:[~2023-06-07 16:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 15:10 [pve-devel] [PATCH common 1/3] fix #3893: network: make bridge vids configurable Aaron Lauterer
2023-04-13 15:10 ` [pve-devel] [PATCH manager 2/3] fix #3893: api: network: add bridge_vids parameter Aaron Lauterer
2023-04-13 15:10 ` [pve-devel] [PATCH widget-toolkit 3/3] fix #3892: NetworkEdit: add bridge vids field for bridge_vids Aaron Lauterer
2023-06-01 14:24 ` Thomas Lamprecht
2023-06-02 13:10 ` Aaron Lauterer
2023-06-07 16:12 ` Thomas Lamprecht [this message]
2023-05-26 8:33 ` [pve-devel] [PATCH common 1/3] fix #3893: network: make bridge vids configurable Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=402ddaae-88d5-c0bc-2ae2-813a36130ff7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.