Re: [pve-devel] applied-series: [PATCH-SERIES v2 manager] stricter storage rules for migration

[Fabian Ebner <f.ebner@proxmox.com>]

Am 21.06.21 um 17:18 schrieb Thomas Lamprecht:
> On 21.06.21 16:31, Fabian Ebner wrote:
>> Changes from v1:
>>      * dropped already applied patches
>>      * rebased
>>      * adapted/improved messages
>>
>> Fabian Ebner (2):
>>    pve6to7: add check for guest images on misconfigured storages
>>    pve6to7: check for misconfigured content type 'none'
>>
>>   PVE/CLI/pve6to7.pm | 50 ++++++++++++++++++++++++++++++++++++++++++++++
>>   1 file changed, 50 insertions(+)
>>
> 
> 
> applied, thanks! I adapted the output a bit to list them newline-separated, was a bit
> clearer here, in my case.
> 
> And maybe we want to further filter those by the ones actually found in VM configs?
> 
> As else it may be a false-positive, e.g., one may have added the same storage twice,
> which can be OK as long as both entries do not share any content-type, as then there
> should be no locking issue or other issues stemming from our base assumption that one
> storage is there only once (a use case could be priv. separation).
> 
> It at least feels a bit odd to me to get warnings for disks which's VMID is neither a
> guest nor a configured anywhere in the cluster.
> 

Makes sense, I'll send a follow-up.