From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v2] ui: Utils: change default Console order for vms
Date: Thu, 22 Apr 2021 10:02:40 +0200 [thread overview]
Message-ID: <3fca81fe-ae3e-088b-5c22-1245db0e8e29@proxmox.com> (raw)
In-Reply-To: <20210422063902.26490-1-d.csapak@proxmox.com>
On 22.04.21 08:39, Dominik Csapak wrote:
> we want to use spice for vms more than xtermjs if both are available
> (since spice must be chosen as display in that case)
> so the resulting order of preference for vms is:
> spice
> xtermjs
> novnc
>
> since all methods work for containers always, there we use
> xtermjs by default, or what is chosen in the datacenter option
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * fixed the default so that it is only 'vv' for vms, not other
> types of consoles (shell, upgrade,..)
>
> www/manager6/Utils.js | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
applied, thanks! But wondering if form VMs noVNC should be the next in line,
as long as the display property of the VM is not set to a serialX console.
next prev parent reply other threads:[~2021-04-22 8:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 6:39 [pve-devel] " Dominik Csapak
2021-04-22 8:02 ` Thomas Lamprecht [this message]
2021-04-22 8:11 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fca81fe-ae3e-088b-5c22-1245db0e8e29@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.