From: Fiona Ebner <f.ebner@proxmox.com>
To: Yuri Konotopov <ykonotopov@gnome.org>,
Dominik Csapak <d.csapak@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH v2 storage 1/1] fix #254: iscsi: allow to configure multiple portals
Date: Tue, 17 Oct 2023 09:07:24 +0200 [thread overview]
Message-ID: <3f89e1fd-f899-4e60-bb2b-7be077af4ade@proxmox.com> (raw)
In-Reply-To: <caccd18c-120d-4734-9d28-f4541f322d1e@gnome.org>
Am 16.10.23 um 18:08 schrieb Yuri Konotopov:
>
> It looks like the return value of iscsi_discovery is not used. So we can
> drop
>
> $res completely and regex too.
>
It is used by the scan/iscsi API endpoint via scan_iscsi() in Storage.pm.
Best Regards,
Fiona
prev parent reply other threads:[~2023-10-17 7:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231015183216.86220-1-ykonotopov@gnome.org>
[not found] ` <20231015183216.86220-2-ykonotopov@gnome.org>
2023-10-16 13:58 ` Dominik Csapak
[not found] ` <caccd18c-120d-4734-9d28-f4541f322d1e@gnome.org>
2023-10-17 7:07 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f89e1fd-f899-4e60-bb2b-7be077af4ade@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=ykonotopov@gnome.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.