From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 1/3] fix #5244 pveceph: install: add new repository for offline installation
Date: Mon, 6 Oct 2025 19:17:13 +0200 [thread overview]
Message-ID: <3f75c823-1d7c-499c-9060-553165c7c3cf@proxmox.com> (raw)
In-Reply-To: <41a317ce-c349-4eef-91c6-d865ce42af6f@proxmox.com>
Am 03.10.25 um 13:52 schrieb Aaron Lauterer:
> ping? patches still apply to latest master
>
It applied alright, but it certainly did not work, not now and not back
then when v2 was submitted, as while you rebased it to avoid merge
conflicts, you seemingly did not check if those conflicts required
adaptions... As with commit 405fcbc1e ("pveceph: switch repo sources
to modern deb822 format") applied on 8th of July, the $repolist variable
name did not exist, nor do we want to setup a deb822 formatted repo
in a .list file made for single-line entries.
Please actually test before submitting a rebase, and FWIW, doing so
wouldn't also hurt before ping'ing.
Fixed above in a follow-up.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-06 17:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 8:38 Aaron Lauterer
2025-07-14 8:38 ` [pve-devel] [PATCH v2 2/3] ui: CephInstallWizard: add option and hint for offline repository Aaron Lauterer
2025-07-14 8:38 ` [pve-devel] [PATCH v2 3/3] pveceph: print repo metadata when installing from manual Aaron Lauterer
2025-07-14 8:45 ` Shannon Sterz
2025-07-14 9:05 ` Aaron Lauterer
2025-10-03 11:51 ` [pve-devel] [PATCH v2 1/3] fix #5244 pveceph: install: add new repository for offline installation Aaron Lauterer
2025-10-06 17:17 ` Thomas Lamprecht [this message]
2025-10-06 15:45 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f75c823-1d7c-499c-9060-553165c7c3cf@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.