From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: Dominik Rusovac <d.rusovac@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-manager] fix #7011: ceph monitor: set ownership of monitor logs
Date: Tue, 16 Dec 2025 13:14:59 +0100 [thread overview]
Message-ID: <3ef61f79-998e-46a1-ba14-ca4277ff482c@proxmox.com> (raw)
In-Reply-To: <s8oa4zi3a2a.fsf@proxmox.com>
Am 16.12.25 um 13:06 schrieb Maximiliano Sandoval:
> Thomas Lamprecht <t.lamprecht@proxmox.com> writes:
>
>> Am 12.12.25 um 14:05 schrieb Dominik Rusovac:
>>> Ownership of ceph logs is now set to ceph:ceph after the creation of a
>>> new monitor and before the new monitor starts. Hence, effective ceph
>>> monitor logging on freshly set up ceph clusters no longer depends on the
>>> first upgrade of ceph-common.
>>
>> Might it be a better fix to then change the postinst script of
>> ceph-common, or whatever packages postinst script creates those
>> directories, to chown them to ceph:ceph? That way it would also work
>> if one installs ceph directly, circumventing pveceph. While that is
>> not exactly something we promote, but it's not really hard, and
>> packaging is often a good place to take care of such things like
>> directory ownership
>
> The directories are created with the right permissions and owner, the
> issue here is that the monitor logs generated when we create the monitor
> (the command above the call introduced by the patch) are created with
> root as the owner.
>
Ok, thanks for your input, I missed your other reply due to searching
explicitly for Dominik's patch due to talking with him in the morning.
Anyhow, then I'd favor addressing the actual root cause in the
"ceph-mon --mkfs" command over this approach here, might not be that
complicated - I'm sure Max might have some pointers or could help, having
wrestled with the ceph tooling in the past.
Again, something like that here can still be fine as stop-gap, but then
I really would use chown function inside a call to dir_glob_regex from
PVE::Tools.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-12-16 12:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-12 13:05 Dominik Rusovac
2025-12-12 15:38 ` Maximiliano Sandoval
2025-12-16 7:25 ` Thomas Lamprecht
2025-12-16 12:06 ` Maximiliano Sandoval
2025-12-16 12:14 ` Thomas Lamprecht [this message]
2025-12-16 12:54 ` Maximiliano Sandoval
2025-12-17 7:33 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ef61f79-998e-46a1-ba14-ca4277ff482c@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.rusovac@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.