Re: [pbs-devel] [PATCH proxmox-backup 1/2] ui: add 'show repository Information' button for datastores

[Dominik Csapak <d.csapak@proxmox.com>]

On 11/29/23 15:53, Thomas Lamprecht wrote:
> Am 29/11/2023 um 12:03 schrieb Dominik Csapak:
>> this has a similar functionality as the 'show fingerprint' button,
>> but for repository strings that are needed e.g. for the cli
>>
>> included with and without the current user for convenience
>>
> 
> datastore should be copyable too, and could be nice if the host (ip or domain,
> maybe just document.location.hostname) would be visble separately too.
> 
> Potentially divide the repo stuff for CLI a bit of with a extra line that
> spots a "Repository for CLI and API" label (or the like)
> 
> W.r.t. button placement, to the contrary of my intial suggestion I might
> prefer it at the start of the summary view's top bar (where the RRD range
> selector is). similar to the "Package Versions" button in PVE's node
> summary.

only there, or leave it at the datastore list summary too?

> 
> An onlineHelp reference to "Backup Repository Locations" as Fabian suggests
> would be really a good idea, as is the missing padding for the copy buttons,
> and those could be a bit less flashy by using the inline buttons (or toolbar
> button, always forget what we/ExtJS name it) styling.
> 

makes all sense, do you have a preference for the button text
(i.e. fabians suggestion 'show client information' or 'show connection info' like you
offlist suggested?)

i'd then have:

datastore
hostname
fingerprint

"repository for cli and api"(
repository
with current user

sounds ok ?