From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Hannes Duerr <h.duerr@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage
Date: Thu, 14 Dec 2023 15:31:51 +0100 [thread overview]
Message-ID: <3ed01e90-2734-410a-8972-46436c0d8eda@proxmox.com> (raw)
In-Reply-To: <bc965cdd-4124-4d11-8d33-e9843cb9613b@proxmox.com>
Am 14.12.23 um 15:23 schrieb Fiona Ebner:
> Am 07.12.23 um 10:12 schrieb Hannes Duerr:
>> +
>> + ($storeid, $volname) = split (/:/, $class->SUPER::volume_import(
>
> Using parse_volid() would be more robust than using an ad-hoc split.
>
Sorry, I meant:
PVE::Storage::parse_volume_id()
next prev parent reply other threads:[~2023-12-14 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 9:12 [pve-devel] [PATCH v2 qemu-server pve-storage 0/2] " Hannes Duerr
2023-12-07 9:12 ` [pve-devel] [PATCH v2 qemu-server pve-storage 1/2] migration: secure and use source volume names for cleanup Hannes Duerr
2023-12-14 13:58 ` Fiona Ebner
2023-12-07 9:12 ` [pve-devel] [PATCH v2 qemu-server pve-storage 2/2] fix #1611: implement import of base-images for LVM-thin Storage Hannes Duerr
2023-12-14 14:23 ` Fiona Ebner
2023-12-14 14:31 ` Fiona Ebner [this message]
2023-12-18 12:02 ` Hannes Dürr
2023-12-18 13:07 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ed01e90-2734-410a-8972-46436c0d8eda@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=h.duerr@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal