[pve-devel] [PATCH installer] install: ask for patience when making system bootable

[pve-devel] [PATCH installer] install: ask for patience when making system bootable

[Christian Ebner]

Making the system bootable can take some time if many disks are used
for installation, which could be misinterpreted as a hanging
installer. Add a please be patient output when more than 3 disks are
used.

Output changes from `make system bootable` to
`make system bootable (please be patient)`

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 Proxmox/Install.pm | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 5c64c3d..5c59485 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -723,6 +723,7 @@ sub extract_data {
     }
 
     my $bootloader_err;
+    my $diskcount = 0;
 
     eval {
 	my $maxper = 0.25;
@@ -761,6 +762,7 @@ sub extract_data {
 	} elsif ($use_btrfs) {
 
 	    my ($devlist, $btrfs_mode) = get_btrfs_raid_setup();
+	    $diskcount = scalar(@$devlist);
 
 	    foreach my $hd (@$devlist) {
 		wipe_disk(@$hd[1]);
@@ -795,6 +797,7 @@ sub extract_data {
 	} elsif ($use_zfs) {
 
 	    my ($devlist, $vdev) = get_zfs_raid_setup();
+	    $diskcount = scalar(@$devlist);
 
 	    foreach my $hd (@$devlist) {
 		wipe_disk(@$hd[1]);
@@ -842,6 +845,7 @@ sub extract_data {
 	} else {
 	    my $target_hd = Proxmox::Install::Config::get_target_hd();
 	    die "target '$target_hd' is not a valid block device\n" if ! -b $target_hd;
+	    $diskcount = 1;
 
 	    wipe_disk($target_hd);
 
@@ -1241,7 +1245,9 @@ _EOD
 	    debconfig_set($targetdir, "pve-manager pve-manager/country string $ucc\n");
 	}
 
-	update_progress(0.8, 0.95, 1, "make system bootable");
+	my $ask_for_patience = "";
+	$ask_for_patience = " (please be patient)" if $diskcount > 3;
+	update_progress(0.8, 0.95, 1, "make system bootable$ask_for_patience");
 	my $target_cmdline='';
 	if ($target_cmdline = Proxmox::Install::Config::get_target_cmdline()) {
 	    my $target_cmdline_snippet = '';
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] install: ask for patience when making system bootable

[Thomas Lamprecht]

Am 15.11.24 um 13:43 schrieb Christian Ebner:
> Making the system bootable can take some time if many disks are used
> for installation, which could be misinterpreted as a hanging
> installer. Add a please be patient output when more than 3 disks are
> used.
> 
> Output changes from `make system bootable` to
> `make system bootable (please be patient)`

What about including the reason for the need to be patient, like e.g.:

make system bootable (multiple disks detected, please be patient)


If you agree, or even have a better proposal for wording it, I can also
squash this in when applying your patch.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] install: ask for patience when making system bootable

[Christian Ebner]

> On 15.11.2024 14:35 CET Thomas Lamprecht <t.lamprecht@proxmox.com> wrote:
> 
>  
> Am 15.11.24 um 13:43 schrieb Christian Ebner:
> > Making the system bootable can take some time if many disks are used
> > for installation, which could be misinterpreted as a hanging
> > installer. Add a please be patient output when more than 3 disks are
> > used.
> > 
> > Output changes from `make system bootable` to
> > `make system bootable (please be patient)`
> 
> What about including the reason for the need to be patient, like e.g.:
> 
> make system bootable (multiple disks detected, please be patient)

Even better, I didn't want to make it to long though. 

> 
> 
> If you agree, or even have a better proposal for wording it, I can also
> squash this in when applying your patch.

Agreed, please feel free to squash in the additional reasoning!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH installer] install: ask for patience when making system bootable

[Thomas Lamprecht]

Am 15.11.24 um 13:43 schrieb Christian Ebner:
> Making the system bootable can take some time if many disks are used
> for installation, which could be misinterpreted as a hanging
> installer. Add a please be patient output when more than 3 disks are
> used.
> 
> Output changes from `make system bootable` to
> `make system bootable (please be patient)`
> 
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  Proxmox/Install.pm | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
>

applied, with change of message squashed in as discusees, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel