all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Nicolas Frey <n.frey@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [RFC cluster/common/container/docs/installer/manager 00/21] add rudimentary host backup mechanism
Date: Tue, 20 Oct 2026 17:47:43 +0200	[thread overview]
Message-ID: <3e24a410-7891-4d35-9e53-3097e8ce6259@proxmox.com> (raw)
In-Reply-To: <20260828133030.351140-1-s.sterz@proxmox.com>

Hi, thanks for the patches!

I tested the changes on the PVE side and the installer (i.e. disaster
recovery) on a VM with zfs on root:

PVE side:

works well, using it is quite intuitive. I didn't run into any issues.
I had some thoughts of how it could be extended:

* allow the user to add additional paths that they might want backed
up too, e.g. custom scripts outside of `/etc`
* allow local backups, which would make it possible to plug it into
own backup scripts/solutions

Both of these are probably beyond the scope of "disaster recovery" and
may also be out of scope for the initial series, but I just wanted to
mention them.

The installer:

I had some difficulties with testing the installer changes, mainly
because it depended on proxmox-backup-client, which isn't in our ISO
build. after getting DNS to work so I could pull in packages via apt,
I was able to install the package.

I was also a bit puzzled by how the restore functioned (I went through
a whole TUI installer dialog until realizing I'd have to pass '-r' to
initiate the process, though that wouldn't be an issue if I didn't
have to start the installer in debug mode and chose a "restore from
backup" option.

Also, manually needing to fill in all the PBS information in the
installer was a bit annoying, though I reckon that would be solved by
the auto-installer.

Perhaps also making it possible to restore from a local backup (not
from PBS) might make sense? It would plug in nicely with the second
point for PVE above.

I otherwise didn't run into any issues on the auto installer, I
restored the VMs (which's config was backed up by the host backup) via
PBS and the single node was running pretty much as it was before.

---

The series looks quite good already!

On 8/28/26 3:31 PM, Shannon Sterz wrote:
> This is still very early stages and rough around the edges. I am sending this
> now, because the rough mechanism seems to work well enough to start gathering
> some input.
[snip]




  parent reply	other threads:[~2026-10-20 15:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-28 13:30 [RFC cluster/common/container/docs/installer/manager 00/21] add rudimentary host backup mechanism Shannon Sterz
2026-08-28 13:30 ` [PATCH cluster 01/21] pmxcfs: status: fix formatting of parameters in checked_mkdir() Shannon Sterz
2026-08-28 13:30 ` [PATCH cluster 02/21] pmxcfs: correctly log message when directory can't be created Shannon Sterz
2026-08-28 13:30 ` [PATCH cluster 03/21] pmxcfs: add live backup capability Shannon Sterz
2026-08-28 13:30 ` [PATCH cluster 04/21] pmxcfs: add ability to query backup progress Shannon Sterz
2026-08-28 13:30 ` [PATCH common 05/21] systemd: move parse_os_release() helper to PVE::Systemd Shannon Sterz
2026-08-28 13:30 ` [PATCH container 06/21] setup: use parse_os_release from PVE::Systemd Shannon Sterz
2026-08-28 13:30 ` [PATCH manager 07/21] jobs/api: add basic host backup job logic Shannon Sterz
2026-08-28 13:30 ` [PATCH manager 08/21] api: cluster: add endpoints for manage host backup jobs Shannon Sterz
2026-08-28 13:30 ` [PATCH manager 09/21] api: node: add endpoints for listing backups for a node Shannon Sterz
2026-08-28 13:30 ` [PATCH manager 10/21] api: host backup: include global, disk and network options for restore Shannon Sterz
2026-08-28 13:30 ` [PATCH manager 11/21] api: host backup: add warnings in case zfs snapdir is disabled Shannon Sterz
2026-08-28 13:30 ` [PATCH manager 12/21] ui: node: add panel to manage backups of a host Shannon Sterz
2026-08-28 13:30 ` [PATCH manager 13/21] ui: dc: add panel for managing host backup jobs Shannon Sterz
2026-08-28 13:30 ` [PATCH installer 14/21] bump proxmox-installer-types to 0.2 Shannon Sterz
2026-08-28 13:30 ` [PATCH installer 15/21] make tidy and clean up whitespace in unconfigured.sh Shannon Sterz
2026-08-28 13:30 ` [PATCH installer 16/21] installer-common: add option to verify TLS connections via callback Shannon Sterz
2026-08-28 13:30 ` [PATCH installer 17/21] low-level-installer: add support for restoring backups Shannon Sterz
2026-08-28 13:30 ` [PATCH installer 18/21] installer-common/tui-installer: implement restore tui Shannon Sterz
2026-08-28 13:30 ` [PATCH installer 19/21] unconfigured: add restore mode to unconfigured.sh Shannon Sterz
2026-08-28 13:30 ` [PATCH installer 20/21] tui-installer: unmount a potentially mounted backup on abort Shannon Sterz
2026-08-28 13:30 ` [PATCH docs 21/21] examples: add example hook script for host backup jobs Shannon Sterz
2026-10-20 15:47 ` Nicolas Frey [this message]
2026-10-21 14:44   ` [RFC cluster/common/container/docs/installer/manager 00/21] add rudimentary host backup mechanism Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e24a410-7891-4d35-9e53-3097e8ce6259@proxmox.com \
    --to=n.frey@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal