From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 25D611FF0AA for ; Tue, 20 Oct 2026 17:47:51 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9F60A2161F; Tue, 20 Oct 2026 17:47:48 +0200 (CEST) Message-ID: <3e24a410-7891-4d35-9e53-3097e8ce6259@proxmox.com> Date: Tue, 20 Oct 2026 17:47:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC cluster/common/container/docs/installer/manager 00/21] add rudimentary host backup mechanism To: pve-devel@lists.proxmox.com References: <20260828133030.351140-1-s.sterz@proxmox.com> Content-Language: en-US From: Nicolas Frey In-Reply-To: <20260828133030.351140-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1792511264005 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.368 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ALHC3WZEJKQS436AN2XC3VV5VDK2ROGV X-Message-ID-Hash: ALHC3WZEJKQS436AN2XC3VV5VDK2ROGV X-MailFrom: n.frey@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hi, thanks for the patches! I tested the changes on the PVE side and the installer (i.e. disaster recovery) on a VM with zfs on root: PVE side: works well, using it is quite intuitive. I didn't run into any issues. I had some thoughts of how it could be extended: * allow the user to add additional paths that they might want backed up too, e.g. custom scripts outside of `/etc` * allow local backups, which would make it possible to plug it into own backup scripts/solutions Both of these are probably beyond the scope of "disaster recovery" and may also be out of scope for the initial series, but I just wanted to mention them. The installer: I had some difficulties with testing the installer changes, mainly because it depended on proxmox-backup-client, which isn't in our ISO build. after getting DNS to work so I could pull in packages via apt, I was able to install the package. I was also a bit puzzled by how the restore functioned (I went through a whole TUI installer dialog until realizing I'd have to pass '-r' to initiate the process, though that wouldn't be an issue if I didn't have to start the installer in debug mode and chose a "restore from backup" option. Also, manually needing to fill in all the PBS information in the installer was a bit annoying, though I reckon that would be solved by the auto-installer. Perhaps also making it possible to restore from a local backup (not from PBS) might make sense? It would plug in nicely with the second point for PVE above. I otherwise didn't run into any issues on the auto installer, I restored the VMs (which's config was backed up by the host backup) via PBS and the single node was running pretty much as it was before. --- The series looks quite good already! On 8/28/26 3:31 PM, Shannon Sterz wrote: > This is still very early stages and rough around the edges. I am sending this > now, because the rough mechanism seems to work well enough to start gathering > some input. [snip]