From: Christian Ebner <c.ebner@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>
Subject: Re: [pbs-devel] applied-series: [PATCH proxmox-backup 0/3] fix #5285: log global statistics for sync job
Date: Thu, 7 Mar 2024 15:11:03 +0100 [thread overview]
Message-ID: <3d94259f-7621-4bea-ae75-efc7749fd910@proxmox.com> (raw)
In-Reply-To: <9eb2e30b-52fd-4624-b2f4-7b653b7bb374@proxmox.com>
On 3/7/24 14:59, Thomas Lamprecht wrote:
>
> Albeit for such things it would be nice to add an example (excerpt) of the
> new message/format in the commit message – I amended the respective commit
> with that.
Thanks, will keep that in mind for next time.
>
> I also found a glitch for the case where no new data was pulled, as then
> one got the following log entry:
>
>> Summary: sync job pulled 0 B in 0 chunks (average rate: NaN B/s) >
> I made a follow-up commit that makes the API log a different messages
> in that case.
Had that case as well, but was thinking of taking a look at how to
better handle such a `NaN` case in the `human_byte` crate. But I agree,
the output is cleaner with your followup.
>
> Something that might be still relevant is mentioning the amount of
> deleted (vanished) backups/groups in the summary.
Okay, will have a look at integrating that as well.
Thanks for your comments and to Max for review and testing!
prev parent reply other threads:[~2024-03-07 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 14:11 [pbs-devel] " Christian Ebner
2024-03-06 14:11 ` [pbs-devel] [PATCH proxmox-backup 1/3] server: sync: return `PullStats` for pull related methods Christian Ebner
2024-03-06 14:11 ` [pbs-devel] [PATCH proxmox-backup 2/3] fix #5285: api: sync: add job summary to task log Christian Ebner
2024-03-06 14:11 ` [pbs-devel] [PATCH proxmox-backup 3/3] server: sync: use HumanByte for task log output Christian Ebner
2024-03-06 17:29 ` [pbs-devel] [PATCH proxmox-backup 0/3] fix #5285: log global statistics for sync job Max Carrara
2024-03-07 10:55 ` Max Carrara
2024-03-07 13:59 ` [pbs-devel] applied-series: " Thomas Lamprecht
2024-03-07 14:11 ` Christian Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d94259f-7621-4bea-ae75-efc7749fd910@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.