From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pbs-devel] [PATCH proxmox 0/9] preparation for websocket api
Date: Wed, 15 Jul 2020 10:31:52 +0200 [thread overview]
Message-ID: <3d3721e0-acd8-3876-7288-aab3c142e7be@proxmox.com> (raw)
In-Reply-To: <1594800868.gpoilatxdp.astroid@nora.none>
On 7/15/20 10:15 AM, Fabian Grünbichler wrote:
> $ cargo test
> [...]
> test src/api/const_regex.rs - const_regex (line 32) ... ok
> test src/tools/vec.rs - tools::vec (line 19) ... ok
> test src/api/router.rs - api::router::Router (line 216) ... ok
> test src/tools/websocket.rs - tools::websocket::FrameHeader::try_from_bytes (line 301) ... FAILED
> test src/tools/websocket.rs - tools::websocket::create_frame (line 112) ... FAILED
> test src/tools/websocket.rs - tools::websocket::create_frame (line 125) ... FAILED
> test src/tools/websocket.rs - tools::websocket::WebSocketWriter (line 182) ... ok
> test src/tools/websocket.rs - tools::websocket::create_frame (line 99) ... FAILED
> test src/tools/vec/byte_vec.rs - tools::vec::byte_vec (line 4) ... ok
> test src/tools/vec/byte_vec.rs - tools::vec::byte_vec::ByteVecExt (line 15) ... ok
> test src/tools/vec/byte_vec.rs - tools::vec::byte_vec::ByteVecExt::grow_uninitialized (line 51) ... ok
> [...]
>
> ?
>
yes, sorry. seems i forgot to run the tests after changing the
create_frame interface....
i'll send a v2 of that patch (6/9; or should i send the whole series again?)
next prev parent reply other threads:[~2020-07-15 8:31 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 11:09 Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 1/9] proxmox/tools/byte_buffer: improve ByteBuffer interface Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 2/9] proxmox/tools/byte_buffer: impl Default Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 3/9] proxmox/tools/websocket: use ready macro for WebSocketWriter Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 4/9] proxmox/tools/websocket: correctly return eof Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 5/9] proxmox/tools/websocket: use io::Error and Result explicitely Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 6/9] proxmox/tools/websocket: improve mask_bytes and create_frame interface Dominik Csapak
2020-07-15 9:08 ` [pbs-devel] [PATCH proxmox v2 " Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 7/9] proxmox/tools/websocket: implement send_control_frame for writer Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 8/9] proxmox/tools/websocket: replace CallBack with a channel Dominik Csapak
2020-07-14 11:09 ` [pbs-devel] [PATCH proxmox 9/9] proxmox/tools/websocket: add WebSocket implementation Dominik Csapak
2020-07-15 8:15 ` [pbs-devel] [PATCH proxmox 0/9] preparation for websocket api Fabian Grünbichler
2020-07-15 8:31 ` Dominik Csapak [this message]
2020-07-15 13:00 ` [pbs-devel] applied: " Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d3721e0-acd8-3876-7288-aab3c142e7be@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.