all lists on lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Wolfgang Bumiller <w.bumiller@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH qemu-server 0/6] Manage [special:cloudinit] in hotplug code
Date: Wed, 16 Nov 2022 18:41:42 +0100	[thread overview]
Message-ID: <3d2259aa-7d92-c5e1-9db4-7122eaa30517@proxmox.com> (raw)
In-Reply-To: <20221116171408.216775-1-w.bumiller@proxmox.com>

Am 16/11/2022 um 18:14 schrieb Wolfgang Bumiller:
> The inital series by Alexandre always dumped this section into the
> config even if no cloud-init was being used and the api to get the
> pending changes performed filtering which should instead be part of the
> hotplug code.
> 
> See the individual commit messages.
> 
> This partially reverts some of Thomas' cleanups as - unless I missed
> something - image generation and writing of the config only happens in
> paths that are already allowed to write it, plus, the hotplug code will
> now fully manage the [special:cloudinit] section, including removing
> values which have been reverted to the state that was used for the last
> cloud-init image generation.
> 
> Wolfgang Bumiller (6):
>   Revert "cloudinit: avoid unsafe write of VM config"
>   Partially-revert "cloudinit: add cloudinit section for current
>     generated config"
>   delay cloudinit generation in hotplug
>   record cloud-init changes in the cloudinit section
>   don't call 'cleanup_config' the cloudinit section
>   drop get_pending_changes and simplify cloudinit_pending api call
> 
>  PVE/API2/Qemu.pm            |  44 ++++++------
>  PVE/QemuServer.pm           | 132 +++++++++++++++++++++++++++++-------
>  PVE/QemuServer/Cloudinit.pm | 122 ++++++---------------------------
>  3 files changed, 153 insertions(+), 145 deletions(-)
> 


applied series, much thanks!




      parent reply	other threads:[~2022-11-16 17:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 17:14 [pve-devel] " Wolfgang Bumiller
2022-11-16 17:14 ` [pve-devel] [PATCH qemu-server 1/6] Revert "cloudinit: avoid unsafe write of VM config" Wolfgang Bumiller
2022-11-16 17:14 ` [pve-devel] [PATCH qemu-server 2/6] Partially-revert "cloudinit: add cloudinit section for current generated config" Wolfgang Bumiller
2022-11-16 17:14 ` [pve-devel] [PATCH qemu-server 3/6] delay cloudinit generation in hotplug Wolfgang Bumiller
2022-11-16 17:14 ` [pve-devel] [PATCH qemu-server 4/6] record cloud-init changes in the cloudinit section Wolfgang Bumiller
2022-11-16 17:14 ` [pve-devel] [PATCH qemu-server 5/6] don't call 'cleanup_config' " Wolfgang Bumiller
2022-11-16 17:14 ` [pve-devel] [PATCH qemu-server 6/6] drop get_pending_changes and simplify cloudinit_pending api call Wolfgang Bumiller
2022-11-16 17:41 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3d2259aa-7d92-c5e1-9db4-7122eaa30517@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=w.bumiller@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal