[pve-devel] [PATCH installer] tree-wide: add serde `derive` where actually needed

[pve-devel] [PATCH installer] tree-wide: add serde `derive` where actually needed

[Christoph Heiss]

Fixes building each crate on their own.

In a full build (e.g. `make deb`), everything pulls in serde with the
`derive` feature anyway and thus does not exihibit any build failures.

Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
Only noticed this by pure chance while using `cargo test -p
proxmox-tui-installer`. Interesting though that a full build does not
break, which is why I didn't notice it until now ..

 proxmox-installer-common/Cargo.toml | 2 +-
 proxmox-post-hook/Cargo.toml        | 2 +-
 proxmox-tui-installer/Cargo.toml    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/proxmox-installer-common/Cargo.toml b/proxmox-installer-common/Cargo.toml
index ef7a614..b97ccaf 100644
--- a/proxmox-installer-common/Cargo.toml
+++ b/proxmox-installer-common/Cargo.toml
@@ -10,7 +10,7 @@ homepage = "https://www.proxmox.com"
 [dependencies]
 anyhow.workspace = true
 regex.workspace = true
-serde.workspace = true
+serde = { workspace = true, features = [ "derive" ] }
 serde_json.workspace = true
 serde_plain.workspace = true
 
diff --git a/proxmox-post-hook/Cargo.toml b/proxmox-post-hook/Cargo.toml
index 3acea6c..a2ca206 100644
--- a/proxmox-post-hook/Cargo.toml
+++ b/proxmox-post-hook/Cargo.toml
@@ -14,5 +14,5 @@ homepage = "https://www.proxmox.com"
 anyhow.workspace = true
 proxmox-auto-installer.workspace = true
 proxmox-installer-common = { workspace = true, features = ["http"] }
-serde.workspace = true
+serde = { workspace = true, features = ["derive"] }
 serde_json.workspace = true
diff --git a/proxmox-tui-installer/Cargo.toml b/proxmox-tui-installer/Cargo.toml
index c7a0e30..4b11576 100644
--- a/proxmox-tui-installer/Cargo.toml
+++ b/proxmox-tui-installer/Cargo.toml
@@ -9,7 +9,7 @@ homepage = "https://www.proxmox.com"
 
 [dependencies]
 proxmox-installer-common.workspace = true
-serde.workspace = true
+serde = { workspace = true, features = ["derive"] }
 serde_json.workspace = true
 regex.workspace = true
 
-- 
2.47.0



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH installer] tree-wide: add serde `derive` where actually needed

[Thomas Lamprecht]

Am 12.11.24 um 13:49 schrieb Christoph Heiss:
> Fixes building each crate on their own.
> 
> In a full build (e.g. `make deb`), everything pulls in serde with the
> `derive` feature anyway and thus does not exihibit any build failures.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Only noticed this by pure chance while using `cargo test -p
> proxmox-tui-installer`. Interesting though that a full build does not
> break, which is why I didn't notice it until now ..
> 
>  proxmox-installer-common/Cargo.toml | 2 +-
>  proxmox-post-hook/Cargo.toml        | 2 +-
>  proxmox-tui-installer/Cargo.toml    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel