Re: [PATCH proxmox v3 1/5] system-report: add crate for shared report generation

[Christian Ebner <c.ebner@proxmox.com>]

On 8/20/26 3:31 PM, Lukas Wagner wrote:
> Hi Erik,
> 
> thanks a lot for tackling this!
> 
> On Tue Aug 11, 2026 at 1:43 PM CEST, Erik Fastermann wrote:
>> Factor the shared report generation from PBS and PDM into a new
>> proxmox-system-report crate, so both generate their reports from a
>> single implementation.
>>
>> The crate defines the common section order (FILES, COMMANDS,
>> FUNCTIONS) and the set of general commands run on every product;
>> products pass their own additional files, commands and functions on
>> top. It produces no report on its own, so the user-visible changes
>> land in the respective server packages.
>>
>> Suggested-by: Lukas Wagner <l.wagner@proxmox.com>
>> Suggested-by: Christian Ebner <c.ebner@proxmox.com>
>> Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
>> Tested-by: Christian Ebner <c.ebner@proxmox.com>
>> Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
>> ---
>>   Cargo.toml                                 |   2 +
>>   proxmox-system-report/Cargo.toml           |  16 ++
>>   proxmox-system-report/debian/control       |  36 ++++
>>   proxmox-system-report/debian/copyright     |  18 ++
>>   proxmox-system-report/debian/debcargo.toml |   7 +
>>   proxmox-system-report/src/lib.rs           | 239 +++++++++++++++++++++
>>   6 files changed, 318 insertions(+)
>>   create mode 100644 proxmox-system-report/Cargo.toml
>>   create mode 100644 proxmox-system-report/debian/control
>>   create mode 100644 proxmox-system-report/debian/copyright
>>   create mode 100644 proxmox-system-report/debian/debcargo.toml
> 
> This is missing a debian/changelog file, without it
> `make proxmox-sytem-report-deb` does not work.
>

That's on me: I suggested to leave it out for the maintainer to set, as 
it will be outdated anyways, see 
https://lore.proxmox.com/pbs-devel/4d0f692b-29a9-4951-830e-efe145f7bbdd@proxmox.com/

[..]