From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 8DCEF1FF0AA for ; Thu, 20 Aug 2026 15:36:57 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5DFE3214CC; Thu, 20 Aug 2026 15:36:57 +0200 (CEST) Message-ID: <3bdff658-0aad-445a-bf4b-647a5e49371b@proxmox.com> Date: Thu, 20 Aug 2026 15:36:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox v3 1/5] system-report: add crate for shared report generation To: Lukas Wagner , Erik Fastermann , pbs-devel@lists.proxmox.com, pdm-devel@lists.proxmox.com References: <20260811114332.283776-1-e.fastermann@proxmox.com> <20260811114332.283776-2-e.fastermann@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1787232988643 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.730 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NR3YJWVMFDJH74K5MPDGBPKV3UVG6QG2 X-Message-ID-Hash: NR3YJWVMFDJH74K5MPDGBPKV3UVG6QG2 X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 8/20/26 3:31 PM, Lukas Wagner wrote: > Hi Erik, > > thanks a lot for tackling this! > > On Tue Aug 11, 2026 at 1:43 PM CEST, Erik Fastermann wrote: >> Factor the shared report generation from PBS and PDM into a new >> proxmox-system-report crate, so both generate their reports from a >> single implementation. >> >> The crate defines the common section order (FILES, COMMANDS, >> FUNCTIONS) and the set of general commands run on every product; >> products pass their own additional files, commands and functions on >> top. It produces no report on its own, so the user-visible changes >> land in the respective server packages. >> >> Suggested-by: Lukas Wagner >> Suggested-by: Christian Ebner >> Reviewed-by: Christian Ebner >> Tested-by: Christian Ebner >> Signed-off-by: Erik Fastermann >> --- >> Cargo.toml | 2 + >> proxmox-system-report/Cargo.toml | 16 ++ >> proxmox-system-report/debian/control | 36 ++++ >> proxmox-system-report/debian/copyright | 18 ++ >> proxmox-system-report/debian/debcargo.toml | 7 + >> proxmox-system-report/src/lib.rs | 239 +++++++++++++++++++++ >> 6 files changed, 318 insertions(+) >> create mode 100644 proxmox-system-report/Cargo.toml >> create mode 100644 proxmox-system-report/debian/control >> create mode 100644 proxmox-system-report/debian/copyright >> create mode 100644 proxmox-system-report/debian/debcargo.toml > > This is missing a debian/changelog file, without it > `make proxmox-sytem-report-deb` does not work. > That's on me: I suggested to leave it out for the maintainer to set, as it will be outdated anyways, see https://lore.proxmox.com/pbs-devel/4d0f692b-29a9-4951-830e-efe145f7bbdd@proxmox.com/ [..]